fix: The XBlock should work even when max_attempts is null

[xitij2000]

Overview

This change allows the XBlock to continue working in cases where max_attempts is set to null. Currently Studio and LMS will throw an error in such a case due to a number of places where max_attempts is compared to count_attempts without testing for None first.

Test Instructions

• Set up this XBlock in a course
• Set the max_attempts in course advanced setting to 1, save, and then set it to null and save
• Test that the XBlock is working

TODO

• Compile static assets
• Lint all files
• Pass all tests
• Bump the version number in setup.py
• Attach screenshots?
• Code Reviewer 1:
• Code Reviewer 2:
• Submit PR against edx-platform to bump the version
• Upload to PyPi

[openedx-webhooks]

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[mphilbrick211]

Hi @openedx/2u-arbi-bom! Would someone be able to please review / merge this for us? Thanks!

[mavidser]

👍

• I tested this: Empty max_attempts is working
• I read through the code

[awais786]

You need to fix the commit message.

 input: fixup: Update tests
✖   type must be one of [revert, feat, fix, perf, docs, test, build, refactor, style, chore, temp] [type-enum]

[xitij2000]

You need to fix the commit message.

 input: fixup: Update tests
✖   type must be one of [revert, feat, fix, perf, docs, test, build, refactor, style, chore, temp] [type-enum]

Done!

[xitij2000]

You need to fix the commit message.

 input: fixup: Update tests
✖   type must be one of [revert, feat, fix, perf, docs, test, build, refactor, style, chore, temp] [type-enum]

Is this good to merge?

[mphilbrick211]

@openedx/2u-arbi-bom hi there! is someone able to take a look at this for us?

[mphilbrick211]

Once someone assigns themselves for review, we can resolve conflicts.