Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep linking target_link_uri and redirect_uri not respected #339

Open
geoff-va opened this issue Mar 6, 2023 · 0 comments
Open

Deep linking target_link_uri and redirect_uri not respected #339

geoff-va opened this issue Mar 6, 2023 · 0 comments

Comments

@geoff-va
Copy link
Contributor

geoff-va commented Mar 6, 2023

  • During a deep link launch, the target_link_uri is set to the lti_1p3_launch_url here as opposed to the lti_advantage_deep_linking_launch_url.
    • I believe we want to be using the lti_advantage_deep_linking_launch_url as the target_link_uri during deep link launch since the normal launch url would be associated with a specific resource link (whereas during deep linking there may not even be a resource link created yet).
  • The redirect_uri is then set to the deep linking launch url instead of respecting (and validating) the redirect_uri returned by the Tool.
    • I believe we should respect the Tool provided redirect_uri (assuming it's in our validate redirect uri's list).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant