feat: use XBlockI18NService js translations | FC-0012 #441
Conversation
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
openedx-webhooks
added
the
open-source-contribution
OmarIthawi
changed the title
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
2 times, most recently
from
16bf96a
to
202cff1
Compare
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
2 times, most recently
from
2c8da86
to
b9afb1e
Compare
ahmadabuwardeh
force-pushed
the
feature/delete_transfix
branch
from
b9afb1e
to
7ef92fc
Compare
|
@shadinaif fyi. |
itsjeyd
added
the
needs test run
|
@itsjeyd all the tests have passed, so removing the label. |
e0d
removed
the
needs test run
|
Thanks @e0d! |
There was a problem hiding this comment.
Thank you Omar, please only fix the i18n_js_namespace name
I've tested it with the name fixed and it's working fine. (local tutor 17.0.2). I didn't connect to a real LTI, I just added a console log, and the translation was pulled successfully console.log(gettext('LTI Consumer'))
| def validate_field_data(self, validation, data): | ||
| # Validate custom parameters is a list. | ||
| if not isinstance(data.custom_parameters, list): | ||
| _ = self.runtime.service(self, "i18n").ugettext | ||
| _ = self.runtime.service(self, 'i18n').ugettext |
There was a problem hiding this comment.
no need
| _ = self.runtime.service(self, 'i18n').ugettext | |
| _ = self.runtime.service(self, "i18n").ugettext |
| @@ -257,6 +258,7 @@ class LtiConsumerXBlock(StudioEditableXBlockMixin, XBlock): | |||
| """ | |||
|
|
|||
| block_settings_key = 'lti_consumer' | |||
| i18n_js_namespace = 'LtiI18N' | |||
There was a problem hiding this comment.
the make file already uses a name, please change this one
| i18n_js_namespace = 'LtiI18N' | |
| i18n_js_namespace = 'XBlockLtiConsumerI18N' |
|
@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thanks @shadinaif. I've closed it. You're right about the minor notes, Ahmed was being onboarded and I just opened the PR for him. Please re-create the PR with your notes resolved. |
|
thank you @OmarIthawi , replaced by this PR #452 |
Implement OEP-58 JavaScript translations
atlas pullfor the edx-platform and its plugins FC-0012 edx-platform#33166atlas pullfor XBlock translations | FC-0012 edx-platform#33698Testing
Reference
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.