chore: optimizations

openedx · Aug 7, 2024 · 0fc1e44 · 0fc1e44
1 parent 39ff513
commit 0fc1e44
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/sample_xblocks/filethumbs/filethumbs.py b/sample_xblocks/filethumbs/filethumbs.py
@@ -70,7 +70,9 @@ def student_view(self, context=None): # pylint: disable=W0613
  """
 
  # Load the HTML fragment from within the package and fill in the template
- html_str = importlib.resources.files(__package__).joinpath("static/html/thumbs.html").read_text()
+ html_str = importlib.resources.files(__package__).joinpath(
+ "static/html/thumbs.html"
+ ).read_text(encoding="utf-8")
  frag = Fragment(str(html_str))
 
  if not self.fs.exists("thumbsvotes.json"):
@@ -83,10 +85,10 @@ def student_view(self, context=None): # pylint: disable=W0613
  self.downvotes = votes['down']
 
  # Load the CSS and JavaScript fragments from within the package
- css_str = importlib.resources.files(__package__).joinpath("static/css/thumbs.css").read_text()
+ css_str = importlib.resources.files(__package__).joinpath("static/css/thumbs.css").read_text(encoding="utf-8")
  frag.add_css(str(css_str))
 
- js_str = importlib.resources.files(__package__).joinpath("static/js/src/thumbs.js").read_text()
+ js_str = importlib.resources.files(__package__).joinpath("static/js/src/thumbs.js").read_text(encoding="utf-8")
  frag.add_javascript(str(js_str))
 
  with self.fs.open('uparrow.png', 'wb') as file_output:

diff --git a/sample_xblocks/thumbs/thumbs.py b/sample_xblocks/thumbs/thumbs.py
@@ -34,14 +34,16 @@ def student_view(self, context=None): # pylint: disable=W0613
  """
 
  # Load the HTML fragment from within the package and fill in the template
- html_str = importlib.resources.files(__package__).joinpath("static/html/thumbs.html").read_text()
+ html_str = importlib.resources.files(
+ __package__
+ ).joinpath("static/html/thumbs.html").read_text(encoding="utf-8")
  frag = Fragment(str(html_str).format(block=self))
 
  # Load the CSS and JavaScript fragments from within the package
- css_str = importlib.resources.files(__package__).joinpath("static/css/thumbs.css").read_text()
+ css_str = importlib.resources.files(__package__).joinpath("static/css/thumbs.css").read_text(encoding="utf-8")
  frag.add_css(str(css_str))
 
- js_str = importlib.resources.files(__package__).joinpath("static/js/src/thumbs.js").read_text()
+ js_str = importlib.resources.files(__package__).joinpath("static/js/src/thumbs.js").read_text(encoding="utf-8")
  frag.add_javascript(str(js_str))
 
  frag.initialize_js('ThumbsBlock')