Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf-compiler not including the protobuf compiler (in sdk) #628

Closed
DAdolfsson opened this issue Oct 21, 2022 · 3 comments
Closed

protobuf-compiler not including the protobuf compiler (in sdk) #628

DAdolfsson opened this issue Oct 21, 2022 · 3 comments

Comments

@DAdolfsson
Copy link

Hi,
I recently attempted to assemble a sdk for one of my colleagues but we had problems.

The SDK was successfully built but no protoc compiler was included.
From what i can tell it was not included in the nativesdk-protobuf-compiler package.

I am far from an expert in this, and lots of the recipe goes above my head.
But, to resolve my issues i changed a single line that looked wrong in the recipe:

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 0bc9cbedc..e7486857f 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -27,7 +27,7 @@ inherit cmake pkgconfig ptest
 PACKAGECONFIG ??= ""
 PACKAGECONFIG:class-native ?= "compiler"
 PACKAGECONFIG[python] = ",,"
-PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
+PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON"
 
 EXTRA_OECMAKE += "\
     -Dprotobuf_BUILD_SHARED_LIBS=ON \

From my understanding of the precompiler, by adding the same variable twice with different values it will only respect the last one.

Best Regards
Daniel

@kraj
Copy link
Contributor

kraj commented Oct 21, 2022

Can you test this patch instead ? and report back if it works

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
index 0bc9cbedc0..c8b9158e6c 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb
@@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest

 PACKAGECONFIG ??= ""
 PACKAGECONFIG:class-native ?= "compiler"
+PACKAGECONFIG:class-nativesdk ?= "compiler"
 PACKAGECONFIG[python] = ",,"
 PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"

@DAdolfsson
Copy link
Author

Thank you,

I it appears to have solved the issue for the generated SDK!

I did a clean-all on the proto* packages and the image.. Verified that the package files was gone and rebuilt..

Now the protoc compiler is present

@DAdolfsson
Copy link
Author

Ah.. just saw that you already included it in master.

Thank you!

quaresmajose pushed a commit to quaresmajose/meta-openembedded that referenced this issue Dec 19, 2022
Changelog:
==========
This release has EDE support, for extended EDNS error reporting,
it fixes unsupported ZONEMD algorithms to load, and has more bug fixes.

The EDE errors can be turned on by 'ede: yes', it is default disabled.
Validation errors and other errors are then reported. If you also want
stale answers for expired responses to have an error code, the option
'ede-serve-expired: yes' can be used.

Features
- Merge PR openembedded#604: Add basic support for EDE (RFC8914).

Bug Fixes
- Fix openembedded#412: cache invalidation issue with CNAME+A.
- Fix that TCP interface does not use TLS when TLS is also configured.
- Fix openembedded#624: Unable to stop Unbound in Windows console (does not
  respond to CTRL+C command).
- Fix openembedded#618: enabling interface-automatic disables DNS-over-TLS.
  Adds the option to list interface-automatic-ports.
- Remove debug info from openembedded#618 fix.
- Fix openembedded#628: A rpz-passthru action is not ending RPZ zone processing.
- Fix for openembedded#628: fix rpz-passthru for qname trigger by localzone type.
- Fix that address not available is squelched from the logs for
  udp connect failures. It is visible on verbosity 4 and more.
- Merge openembedded#631 from mollyim: Replace OpenSSL's ERR_PACK with
  ERR_GET_REASON.
- Fix to detect that no IPv6 support means that IPv6 addresses are
  useless for delegation point lookups.
- update Makefile dependencies.
- Fix check interface existence for support detection in remote lookup.
- Fix openembedded#633: Document unix domain socket support for unbound-control.
- Fix for openembedded#633: updated fix with new text.
- Fix edns client subnet to add the option based on the option list,
  so that it is not state dependent, after the state fix of openembedded#605 for
  double EDNS options.
- Fix for edns client subnet option add fix in removal code, from review.
- Fix openembedded#630: Unify the RPZ log messages.
- Merge openembedded#623 from rex4539: Fix typos.
- Fix pythonmod for change in iter_dp_is_useless function prototype.
- Fix compile warnings for printf ll format on mingw compile.
- Merge PR openembedded#632 from scottrw93: Match cnames in ipset.
- Various fixes for openembedded#632: variable initialisation, convert the qinfo
  to str once, accept trailing dot in the local-zone ipset option.
- Fix openembedded#637: Integer Overflow in sldns_str2period function.
- Fix for openembedded#637: fix integer overflow checks in sldns_str2period.
- Fix configure for python to use sysutils, because distutils is
  deprecated. It uses sysutils when available, distutils otherwise.
- Merge openembedded#644: Make 'install-lib' make target install the pkg-config
  file.
- Fix to ensure uniform handling of spaces and tabs when parsing RRs.
- Fix to describe auth-zone and other configuration at the local-zone
  configuration option, to allow for more broadly view of the options.
- Merge PR openembedded#648 from eaglegai: fix -q doesn't work when use with
  'unbound-control stats_shm'.
- Fix openembedded#651: [FR] Better logging for refused queries.
- Fix spelling error in comment in sldns_str2wire_svcparam_key_lookup.
- Fix zonemd check to allow unsupported algorithms to load.
  If there are only unsupported algorithms, or unsupported schemes,
  and no failed or successful other ZONEMD records, or malformed
  or bad ZONEMD records, the unsupported records allow the zone load.
- Fix zonemd unsupported algo check.
- Fix zonemd unsupported algo check reason to not copy to next record,
  and check for success for debug printout.
- Fix zonemd unsupported algo check to print unsupported reason before
  zeroing it.
- Fix zonemd unsupported algo check to set reason to NULL before the
  check routine, but after malformed checks, to get the correct NULL
  output when the digest matches.
- Fix openembedded#670: SERVFAIL problems with unbound 1.15.0 running on
  OpenBSD 7.1.
- Fix Python build in non-source directory; based on patch by
  Michael Tokarev.
- Fix openembedded#673: DNS over TLS: error: SSL_handshake syscall: No route to
  host.
- Merge openembedded#677: Allow using system certificates not only on Windows,
  from pemensik.
- For openembedded#677: Added tls-system-cert to config parser and documentation.
- Fix openembedded#417: prefetch and ECS causing cache corruption when used
  together.
- Fix openembedded#678: [FR] modify behaviour of unbound-control rpz_enable zone,
  by updating unbound-control's documentation.
- Fix typos in config_set_option for the 'num-threads' and
  'ede-serve-expired' options.
- Fix to silence test for ede error output to the console from the
  test setup script.
- Fix ede test to not use default pidfile, and use local interface.
- Fix some lint type warnings.
- Fix openembedded#684: [FTBS] configure script error with libmnl on openSUSE 15.3
  (and possibly other distributions)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 20, 2022
Changelog:
==========
 Fix comments generation for submessages (openembedded#788)
 Fix handling of spaces in arguments passed through protoc (openembedded#810)
 Fix problems with multiple files and mangle_names option (openembedded#783, openembedded#820)
 Fix generator error when using M_STRIP_PACKAGE without package name (openembedded#795)
 Fix compilation error with fixed size array and FT_POINTER (openembedded#630)
 Fix wrong format in Python Poetry project file (openembedded#811)
 Fix unnecessary generator message when using --quiet (openembedded#831)
 Fix enum_to_string with C++ (openembedded#838)
 Fix /* */ inside .proto file comment
 Workaround python-protobuf version issues (openembedded#787)
 Safeguard substraction in pb_read() with custom streams (openembedded#697)
 Always include pb_release() as function, instead of macro. (openembedded#802)
 Allow using = instead of : with generator option -s
 Allow specifying include format without special characters (openembedded#810)
 Allow including headers from inside of extern C (openembedded#814)
 Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (openembedded#601)
 Add compile-time error message for when PB_FIELD_32BIT is needed (openembedded#680, openembedded#827)
 Add --c-style command line option for naming style (openembedded#199, openembedded#533, openembedded#791)
 Add --protoc-opt to nanopb_generator.py (openembedded#628)
 Add ENUMTYPE convenience macros (openembedded#803)
 Add Bazel build rules (openembedded#360, openembedded#500)
 Generator: keep order of messages when possible
 Test case improvements (openembedded#792)
 PlatformIO build rule improvements (openembedded#808, openembedded#809, openembedded#819, openembedded#834, openembedded#839, openembedded#840)
 CMake build rule improvements (openembedded#822)
 CMakeLists: use protoc wrapper script by default (openembedded#769)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 20, 2022
Changelog:
==========
 Fix comments generation for submessages (openembedded#788)
 Fix handling of spaces in arguments passed through protoc (openembedded#810)
 Fix problems with multiple files and mangle_names option (openembedded#783, openembedded#820)
 Fix generator error when using M_STRIP_PACKAGE without package name (openembedded#795)
 Fix compilation error with fixed size array and FT_POINTER (openembedded#630)
 Fix wrong format in Python Poetry project file (openembedded#811)
 Fix unnecessary generator message when using --quiet (openembedded#831)
 Fix enum_to_string with C++ (openembedded#838)
 Fix /* */ inside .proto file comment
 Workaround python-protobuf version issues (openembedded#787)
 Safeguard substraction in pb_read() with custom streams (openembedded#697)
 Always include pb_release() as function, instead of macro. (openembedded#802)
 Allow using = instead of : with generator option -s
 Allow specifying include format without special characters (openembedded#810)
 Allow including headers from inside of extern C (openembedded#814)
 Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (openembedded#601)
 Add compile-time error message for when PB_FIELD_32BIT is needed (openembedded#680, openembedded#827)
 Add --c-style command line option for naming style (openembedded#199, openembedded#533, openembedded#791)
 Add --protoc-opt to nanopb_generator.py (openembedded#628)
 Add ENUMTYPE convenience macros (openembedded#803)
 Add Bazel build rules (openembedded#360, openembedded#500)
 Generator: keep order of messages when possible
 Test case improvements (openembedded#792)
 PlatformIO build rule improvements (openembedded#808, openembedded#809, openembedded#819, openembedded#834, openembedded#839, openembedded#840)
 CMake build rule improvements (openembedded#822)
 CMakeLists: use protoc wrapper script by default (openembedded#769)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 21, 2022
Changelog:
==========
 Fix comments generation for submessages (openembedded#788)
 Fix handling of spaces in arguments passed through protoc (openembedded#810)
 Fix problems with multiple files and mangle_names option (openembedded#783, openembedded#820)
 Fix generator error when using M_STRIP_PACKAGE without package name (openembedded#795)
 Fix compilation error with fixed size array and FT_POINTER (openembedded#630)
 Fix wrong format in Python Poetry project file (openembedded#811)
 Fix unnecessary generator message when using --quiet (openembedded#831)
 Fix enum_to_string with C++ (openembedded#838)
 Fix /* */ inside .proto file comment
 Workaround python-protobuf version issues (openembedded#787)
 Safeguard substraction in pb_read() with custom streams (openembedded#697)
 Always include pb_release() as function, instead of macro. (openembedded#802)
 Allow using = instead of : with generator option -s
 Allow specifying include format without special characters (openembedded#810)
 Allow including headers from inside of extern C (openembedded#814)
 Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (openembedded#601)
 Add compile-time error message for when PB_FIELD_32BIT is needed (openembedded#680, openembedded#827)
 Add --c-style command line option for naming style (openembedded#199, openembedded#533, openembedded#791)
 Add --protoc-opt to nanopb_generator.py (openembedded#628)
 Add ENUMTYPE convenience macros (openembedded#803)
 Add Bazel build rules (openembedded#360, openembedded#500)
 Generator: keep order of messages when possible
 Test case improvements (openembedded#792)
 PlatformIO build rule improvements (openembedded#808, openembedded#809, openembedded#819, openembedded#834, openembedded#839, openembedded#840)
 CMake build rule improvements (openembedded#822)
 CMakeLists: use protoc wrapper script by default (openembedded#769)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
halstead pushed a commit that referenced this issue Dec 23, 2022
Changelog:
==========
 Fix comments generation for submessages (#788)
 Fix handling of spaces in arguments passed through protoc (#810)
 Fix problems with multiple files and mangle_names option (#783, #820)
 Fix generator error when using M_STRIP_PACKAGE without package name (#795)
 Fix compilation error with fixed size array and FT_POINTER (#630)
 Fix wrong format in Python Poetry project file (#811)
 Fix unnecessary generator message when using --quiet (#831)
 Fix enum_to_string with C++ (#838)
 Fix /* */ inside .proto file comment
 Workaround python-protobuf version issues (#787)
 Safeguard substraction in pb_read() with custom streams (#697)
 Always include pb_release() as function, instead of macro. (#802)
 Allow using = instead of : with generator option -s
 Allow specifying include format without special characters (#810)
 Allow including headers from inside of extern C (#814)
 Add option NANOPB_PB2_TEMP_DIR to store nanopb_pb2.py in a temporary dir (#601)
 Add compile-time error message for when PB_FIELD_32BIT is needed (#680, #827)
 Add --c-style command line option for naming style (#199, #533, #791)
 Add --protoc-opt to nanopb_generator.py (#628)
 Add ENUMTYPE convenience macros (#803)
 Add Bazel build rules (#360, #500)
 Generator: keep order of messages when possible
 Test case improvements (#792)
 PlatformIO build rule improvements (#808, #809, #819, #834, #839, #840)
 CMake build rule improvements (#822)
 CMakeLists: use protoc wrapper script by default (#769)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jun 11, 2024
WirePlumber 0.5.3
~~~~~~~~~~~~~~~~~

Fixes:

  - Fixed a long standing issue that would cause many device nodes to have
    inconsistent naming, with a '.N' suffix (where N is a number >= 2) being
    appended at seemingly random times (openembedded#500)

  - Fixed an issue that would cause unavailable device profiles to be selected
    if they were previously stored in the state file, sometimes requiring users
    to manually remove the state file to get things working again (openembedded#613)

  - Fixed an occasional crash that could sometimes be triggered by hovering
    the volume icon on the KDE taskbar, and possibly other similar actions
    (openembedded#628, !644)

  - Fixed camera device deduplication logic when the same device is available
    through both V4L2 and libcamera, and the libcamera one groups multiple V4L2
    devices together (openembedded#623, !636)

  - Fixed applying the default volume on streams that have no volume previously
    stored in the state file (openembedded#655)

  - Fixed an issue that would prevent some camera nodes - in some cases -
    from being destroyed when the camera device is removed (openembedded#640)

  - Fixed an issue that would cause video stream nodes to be linked with audio
    smart filters, if smart audio filters were configured (!647)

  - Fixed an issue that would cause WP to re-activate device profiles even
    though they were already active (!639)

  - Configuration files in standard JSON format (starting with a '{', among
    other things) are now correctly parsed (openembedded#633)

  - Fixed overriding non-container values when merging JSON objects (openembedded#653)

  - Functions marked with WP_PRIVATE_API are now also marked as
    non-introspectable in the gobject-introspection metadata (openembedded#599)

Improvements:

  - Logging on the systemd journal now includes the log topic and also the log
    level and location directly on the message string when the log level is
    high enough, which is useful for gathering additional context in logs
    submitted by users (!640)

  - Added a video-only profile in wireplumber.conf, for systems where only
    camera & screensharing are to be used (openembedded#652)

  - Improved seat state monitoring so that Bluetooth devices are only enabled
    when the user is active on a local seat, instead of allowing remote users
    as well (!641)

  - Improved how main filter nodes are detected for the smart filters (!642)

  - Added Lua method to merge JSON containers (!637)

Signed-off-by: Markus Volk <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
pratheekshasn pushed a commit to pratheekshasn/meta-openembedded that referenced this issue Sep 11, 2024
…edded#640

Signed-off-by: Chaitanya Vadrevu <[email protected]>
(cherry picked from commit d8e0a298f58ec672840587b09533707c2b0e49fe)
Signed-off-by: Alex Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants