-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta python merge 05/11/2021 #356
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that WORDSIZE is as per the target, currently this does not get it right for cross-compilation env, and OE uses multilib headers by default ( even when you do not use multilib ) which means if WORDSIZE is wrong it will go on to include wrong headers due to these artificial stubs Fixes swig -python -py3 -ITOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../lib/aarch64-oe-linux/gcc/aarch64-oe-linux/11.1.0/include -ITOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../lib/aarch64-oe-linux/gcc/aarch64-oe-linux/11.1.0/include-fixed -ITOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot/usr/lib/aarch64-oe-linux/11.1.0/include -ITOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot/usr/include -ITOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot/usr/include -ITOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot/usr/include/python3.9 -I/usr/include/openssl -includeall -modern -builtin -outdir TOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/M2Crypto-0.37.1/M2Crypto -o SWIG/_m2crypto_wrap.c SWIG/_m2crypto.i TOPDIR/tmp-glibc/work/cortexa57-oe-linux/python3-m2crypto/0.37.1-r0/recipe-sysroot/usr/include/openssl/opensslconf.h:23: Error: Unable to find 'openssl/opensslconf-32.h' Signed-off-by: Khem Raj <[email protected]> Cc: Martin Jansa <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Fixes TOPDIR/build/tmp/work/riscv64-yoe-linux/python3-lazy-object-proxy/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3: No module named pip Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
It has been moved to oe-core Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 0.9.0: - Modified the --timestats general option from boolean to choice with 3 choices for when statistics are displayed (after each command or via a command). - Fixed a ValueError on Windows that was raised when the connections file was not on the home drive. - Limit click package to < 8.0 because of a) incompatibility with python 2.7, b) incompatibility between click 8.0 and clicl-repl. - Limit mock package to lt 4.0.3 to avoid issue issue that causes test failure. - Fix issue caused by mock package version 4.0.3 by creating replacements for warnings.warn and warnings.warn_explicit functions and removing the use of the patch decorator in pywbemcli.py before the definition of the cli function. - Fixes issue where in pywbemcli the --timeout and --use-pull general options were not always correctly included in the new object context in interactive mode if they were specified on the interactive mode cmd line. - Fixed issue in tests with use of stdin and inputting the instance path for instance get and instance delete. This was a test setup issue and not a code issue. - Mitigated the coveralls HTTP status 422 by pinning coveralls-python to <3.0.0. - Fix issue where documentation index disappeared when we changed the documentation theme - Test: Fixed behavior of 'pdb' test condition, which is supposed to stop in the pdb debugger before executing the command function, but did immediately leave the debugger again because of redirections of the standard streams. The debugger now properly comes up when 'pdb' is specified as a condition. - Test: Fixed restoring of environment variables that are modified by testcases, and displaying of PYWBEMCLI environment variables during testing in verbose mode. - Change MOFCompiler.add_mof/remove_mof() to only display exceptions received if not MOFCompileError since the MOF compiler logs all MOFCompileError exceptions. Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 3.5.0: - Add intword processing for thousands - Update translation .po files with 'thousand' - Remove generated translation binaries from repo Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 2.2.2: - Fix issue sissaschool/xmlschema#243 (assert with xsi:nil usage) - First implementation of XPath 3.0 fn:format-integer Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 3.10.0.0: - Implement TypeGuard (PEP 649) - backport ParamSpecArgs/Kwargs - Fixed required/optional keys with old-style TypedDict - Support PEP 612 in typing_extensions (Python 3) Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 2.1.0: - [inotify] Simplify libc loading - [mac] Add support for non-recursive watches in FSEventsEmitter - [watchmedo] Add support for --debug-force-* arguments to tricks Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 1.1.0: - Add support for Python 3.10. Pre-built binary wheels for 3.10 are not currently available for all platforms. The greenlet ABI is different on Python 3.10 from all previous versions, but as 3.10 was never supported before, and the ABI has not changed on other Python versions, this is not considered a reason to change greenlet's major version. Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 2.1.0: - add `.find()` method - `.find()`, `.index()`, `.search()` and `.itersearch()` now all except both (sub-) bitarray as well as bool items to be searched for - improve encode/decode error messages - add lexicographical permutations example - add tests Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 9.0.1: - Fixed issues with the packaging of the 9.0 release. - :class:`~datastructures.Headers` and :exc:`~datastructures.MultipleValuesError` were moved from websockets.http to :mod:`websockets.datastructures`. If you're using them, you should adjust the import path. - The client, server, protocol, and auth modules were moved from the websockets package to websockets.legacy sub-package, as part of an upcoming refactoring. Despite the name, they're still fully supported. The refactoring should be a transparent upgrade for most uses when it's available. The legacy implementation will be preserved according to the backwards-compatibility policy. - The framing, handshake, headers, http, and uri modules in the websockets package are deprecated. These modules provided low-level APIs for reuse by other WebSocket implementations, but that never happened. Keeping these APIs public makes it more difficult to improve websockets for no actual benefit. - Added compatibility with Python 3.9. - Added support for IRIs in addition to URIs. - Added close codes 1012, 1013, and 1014. - Raised an error when passing a :class:`dict` to :meth:`~legacy.protocol.WebSocketCommonProtocol.send`. - Fixed sending fragmented, compressed messages. - Fixed Host header sent when connecting to an IPv6 address. - Fixed creating a client or a server with an existing Unix socket. - Aligned maximum cookie size with popular web browsers. - Ensured cancellation always propagates, even on Python versions where :exc:`~asyncio.CancelledError` inherits :exc:`Exception`. - Improved error reporting. License-Update: Update years Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 2.9.1: - The internal locale-data loading functions now validate the name of the locale file to be loaded and only allow files within Babel's data directory. Thanks to Chris Lyne of Tenable, Inc. for discovering the issue! License-Update: Update years Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
Upgrade to release 1.0.13: - Fix ZeroDivisionError with * * R/0 * * Signed-off-by: Leon Anavi <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
package examples under source into python3-paho-mqtt-examples Signed-off-by: Changqing Li <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
merged now |
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 20, 2022
changelogs: ============================================================= Truncate input after cursor. Fixes openembedded#351 (openembedded#352) Support of path completion in fish openembedded#327 (openembedded#359) Drop support for Python 2.7 and 3.5 (openembedded#361) Add support for Python 3.10 (openembedded#356) Test, documentation, and release infrastructure improvements Signed-off-by: Xu Huan <[email protected]> Signed-off-by: Khem Raj <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 20, 2022
changelogs: ============================================================= Truncate input after cursor. Fixes openembedded#351 (openembedded#352) Support of path completion in fish openembedded#327 (openembedded#359) Drop support for Python 2.7 and 3.5 (openembedded#361) Add support for Python 3.10 (openembedded#356) Test, documentation, and release infrastructure improvements Signed-off-by: Xu Huan <[email protected]> Signed-off-by: Khem Raj <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Jan 20, 2022
changelogs: ============================================================= Truncate input after cursor. Fixes openembedded#351 (openembedded#352) Support of path completion in fish openembedded#327 (openembedded#359) Drop support for Python 2.7 and 3.5 (openembedded#361) Add support for Python 3.10 (openembedded#356) Test, documentation, and release infrastructure improvements Signed-off-by: Xu Huan <[email protected]> Signed-off-by: Khem Raj <[email protected]>
halstead
pushed a commit
that referenced
this pull request
Jan 21, 2022
changelogs: ============================================================= Truncate input after cursor. Fixes #351 (#352) Support of path completion in fish #327 (#359) Drop support for Python 2.7 and 3.5 (#361) Add support for Python 3.10 (#356) Test, documentation, and release infrastructure improvements Signed-off-by: Xu Huan <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
rtollert
pushed a commit
to rtollert/meta-openembedded
that referenced
this pull request
Aug 4, 2022
Version 2.11 ============ Released 2018-02-09 * New features: - Add `json_pack()` format specifiers s*, o* and O* for values that can be omitted if null (openembedded#339). - Add `json_error_code()` to retrieve numeric error codes (openembedded#365, openembedded#380, openembedded#381). - Enable thread safety for `json_dump()` on all systems. Enable thread safe `json_decref()` and `json_incref()` for modern compilers (openembedded#389). - Add `json_sprintf()` and `json_vsprintf()` (openembedded#393). * Bug Fixes: - Fix incorrect report of success from `json_dump_file()` when an error is returned by `fclose()` (openembedded#359). - Make json_equal() const-correct (openembedded#344). - Fix incomplete stealing of references by `json_pack()` (openembedded#374). * Build: - Work around gcc's -Wimplicit-fallthrough. - Fix CMake detection of `sys/types.h` header (openembedded#375). - Fix `jansson.pc` generated by CMake to be more consistent with the one generated using GNU Autotools (openembedded#368). * Other: - Miscellaneous documentation fixes (openembedded#356, openembedded#378, openembedded#395). - Remove unnecessary reference actions from parsers (openembedded#377). Version 2.10 ============ Released 2017-03-02 * New features: - Add JSON_EMBED encoding flag allowing arrays and objects to be encoded into existing streams (openembedded#329). - Add `json_dumpb()` function for dumping to a pre-allocated buffer (openembedded#328). - Add `json_dumpfd()` and `json_loadfd()` functions for dumping to streaming file descriptors (openembedded#328). - Add support for parsing buffers larger than 2GB (openembedded#309). * Build: - Fix CMake build when LONG_LONG_INT is defined as "" (openembedded#321) * Other: - Internal code cleanup (openembedded#311, openembedded#314) Signed-off-by: Andre McCurdy <[email protected]> Signed-off-by: Khem Raj <[email protected]>
rtollert
pushed a commit
to rtollert/meta-openembedded
that referenced
this pull request
Aug 9, 2022
Version 2.11 ============ Released 2018-02-09 * New features: - Add `json_pack()` format specifiers s*, o* and O* for values that can be omitted if null (openembedded#339). - Add `json_error_code()` to retrieve numeric error codes (openembedded#365, openembedded#380, openembedded#381). - Enable thread safety for `json_dump()` on all systems. Enable thread safe `json_decref()` and `json_incref()` for modern compilers (openembedded#389). - Add `json_sprintf()` and `json_vsprintf()` (openembedded#393). * Bug Fixes: - Fix incorrect report of success from `json_dump_file()` when an error is returned by `fclose()` (openembedded#359). - Make json_equal() const-correct (openembedded#344). - Fix incomplete stealing of references by `json_pack()` (openembedded#374). * Build: - Work around gcc's -Wimplicit-fallthrough. - Fix CMake detection of `sys/types.h` header (openembedded#375). - Fix `jansson.pc` generated by CMake to be more consistent with the one generated using GNU Autotools (openembedded#368). * Other: - Miscellaneous documentation fixes (openembedded#356, openembedded#378, openembedded#395). - Remove unnecessary reference actions from parsers (openembedded#377). Version 2.10 ============ Released 2017-03-02 * New features: - Add JSON_EMBED encoding flag allowing arrays and objects to be encoded into existing streams (openembedded#329). - Add `json_dumpb()` function for dumping to a pre-allocated buffer (openembedded#328). - Add `json_dumpfd()` and `json_loadfd()` functions for dumping to streaming file descriptors (openembedded#328). - Add support for parsing buffers larger than 2GB (openembedded#309). * Build: - Fix CMake build when LONG_LONG_INT is defined as "" (openembedded#321) * Other: - Internal code cleanup (openembedded#311, openembedded#314) Signed-off-by: Andre McCurdy <[email protected]> Signed-off-by: Khem Raj <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Feb 16, 2023
0002-iscsiuio-Use-pthread_t-for-INVALID_THREAD.patch removed since it's included in 2.1.8. 0001-Makefile-Do-not-set-Werror.patch refreshed for 2.1.8 Changelog: =========== make: avoid hard-coding path to sed (openembedded#357) etc: install system unit with without executable bit (openembedded#354) Add ability for MGMT IPC to check UID only Use config for iscsistart and iscsiadm fw login iscsiuio: Use pthread_t for INVALID_THREAD (openembedded#363) Add a 'distclean' Makefile top-level target Cleanup fwparam makefile (openembedded#360) Small bug fixes (openembedded#364) Use meson as the main build system (openembedded#365) libopeniscsiusr: cleanup recent reallocarray->realloc change (openembedded#369) Added examples in man file for iscsiadm session commands. iscsid: fix logout pdu send failure handling Update README's error handler/timeout section iscsiuio: fix LDADD libopeniscsiusr: use realloc instead of reallocarray (openembedded#368) iscsiadm: enable specify iface name-value parameters when creating iface Fix a possible passing null pointer in usr/iface.c (openembedded#356) Signed-off-by: Wang Mingyu <[email protected]> Signed-off-by: Khem Raj <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Feb 17, 2023
0002-iscsiuio-Use-pthread_t-for-INVALID_THREAD.patch removed since it's included in 2.1.8. 0001-Makefile-Do-not-set-Werror.patch refreshed for 2.1.8 Changelog: =========== make: avoid hard-coding path to sed (openembedded#357) etc: install system unit with without executable bit (openembedded#354) Add ability for MGMT IPC to check UID only Use config for iscsistart and iscsiadm fw login iscsiuio: Use pthread_t for INVALID_THREAD (openembedded#363) Add a 'distclean' Makefile top-level target Cleanup fwparam makefile (openembedded#360) Small bug fixes (openembedded#364) Use meson as the main build system (openembedded#365) libopeniscsiusr: cleanup recent reallocarray->realloc change (openembedded#369) Added examples in man file for iscsiadm session commands. iscsid: fix logout pdu send failure handling Update README's error handler/timeout section iscsiuio: fix LDADD libopeniscsiusr: use realloc instead of reallocarray (openembedded#368) iscsiadm: enable specify iface name-value parameters when creating iface Fix a possible passing null pointer in usr/iface.c (openembedded#356) Signed-off-by: Wang Mingyu <[email protected]> Signed-off-by: Khem Raj <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 29, 2023
…325338b6e7b3d42de) Drop patches now part of new upstream release: - 0001-Fix-memory-leak.patch - 0001-cmake-Link-with-libatomic-on-rv32-rv64.patch - 0001-dlt-system-Fix-buffer-overflow-detection-on-32bit-ta.patch Cherry-pick and propose upstream two patches to fix build failures with security hardening flags enabled and with some systemd configuration (underlink) - 481.patch - 482.patch Add new dlt-adaptor-stdin cmake optional flag Drop PV variable, not needed anymore Drop latomic manual added flag, upstream code changed to avoid its need See: COVESA/dlt-daemon#433 and COVESA/dlt-daemon@2224cdd (changed from atomic_bool to atomic_int, the latter doesn't require manual atomic library link since it can be optimized properly by the compiler on riscv platforms) What's Changed: dlt-system: fix a libc buffer overflow detection on 32bit targets by @mtitinger in openembedded#337 dlt-daemon: create sockets using "android way" by @sebastienraillet in openembedded#333 fixes compilation issue with clang by @sebastienraillet in openembedded#339 dlt-daemon: Only create directories if they do not exist yet by @alexmohr in openembedded#340 dlt-system : fix invalid free with ConfigurationFileName by @mtitinger in openembedded#342 fix for the issue openembedded#341 by @rvalovyi in openembedded#347 Forcibly the severity level set by @dhnatiuk1 in openembedded#346 fix -Wformat issues reported by clang by @sebastienraillet in openembedded#349 dlt-system: fix invalid free by removing unused TempDir by @andreirusu96 in openembedded#350 Support for Cygwin toolchain. by @DoctorNoobingstoneIPresume in openembedded#351 filetransfer: Return error if no free space by @ssugiura in openembedded#354 lib: Correct VARI usage in dlt_user_log_write_uint by @ssugiura in openembedded#356 Fix DLT User/Client tests by @andreirusu96 in openembedded#357 tests: Deplicate unused files and variables by @ssugiura in openembedded#359 Fix the target name in documentation by @mawillers in openembedded#372 cmake: Add option to enable each adaptor by itself by @alexmohr in openembedded#364 cmake: Add options to enable/disable each dlt console tool by @alexmohr in openembedded#363 filetransfer: Fix getFileCreationDate2 stat check by @andreirusu96 in openembedded#361 dlt_config_file_parser.c:Fix a pointer release bug in the file。 by @Leslie-bcy in openembedded#376 Update workflow by @thanhbnq in openembedded#389 README: Update link to github actions by @ssugiura in openembedded#392 Fix handle returned value by @thanhbnq in openembedded#384 systemd: install adaptor-udp service for adaptor=on by @danielweber2018 in openembedded#393 automotive-dlt.pc: add the path to find the static library by @zeerd in openembedded#387 enforce-trace-limit: ContextLogLevel is now enforced in the daemon by @alexmohr in openembedded#382 dlt-daemon-connection: Start up even if not all bindings are valid by @alexmohr in openembedded#380 dlt_common.c: Change default logging_mode by @wusto in openembedded#406 logstorage: Truncate ECUid in Logstorage filter to prevent crash by @andreirusu96 in openembedded#402 Update dlt_for_developers.md by @marques-bruno in openembedded#405 dlt-gateway: Fix crash on invalid ip by @alexmohr in openembedded#381 dlt_client:Block in connect() by @thanhbnq in openembedded#409 dlt_daemon_client: Fix change loglevel of application by @lti9hc in openembedded#408 Update maintainer by @thanhbnq in openembedded#410 systemd: add support for socket activation via systemd by @alexmohr in openembedded#401 internal-logging: Fix issues with file logging by @alexmohr in openembedded#378 dlt_common: change output of message for log initialization by @lti9hc in openembedded#412 Avoid memory corruption behind buffer wp in function dlt_getloginfo_conv_ascii_to_id by @michael-methner in openembedded#411 dlt_daemon_client: Fix Control Msg ECUId comparison with active Gateway by @andreirusu96 in openembedded#414 Fix for Resource and Memory Leak by @lti9hc in openembedded#418 dlt-receive: set host interface and allow multiple udp multicast addresses by @thanhbnq in openembedded#420 dlt-system: Fix buffer overflow detection on 32bit targets by @sandy-lcq in openembedded#398 cmake: network trace enable toggle by @danielweber2018 in openembedded#424 client: Fix Get Log Info response conversion method by @andreirusu96 in openembedded#422 filetransfer: fix filesize divisible by blocksize case by @danielweber2018 in openembedded#383 Updates for Coding Styles by @thanhbnq in openembedded#425 gateway: Fix Node handling and ECUid checks by @andreirusu96 in openembedded#429 Update contacts and removed mailing lists by @michael-methner in openembedded#431 dlt-user: Fix crashes in dlt_free during dlt_init by @alexmohr in openembedded#362 dlt-convert: Fix memory leak by calling dlt_file_free by @lvklevankhanh in openembedded#434 dlt-user: fix potential non closed socket in init/free by @alexmohr in openembedded#435 Check for negative index in dlt_file_message by @michael-methner in openembedded#437 Fix memory leak by @lvklevankhanh in openembedded#441 dlt-connection: add socket timeout by @alexmohr in openembedded#439 Installs dlt.conf on android by @sebastienraillet in openembedded#446 This changes a mispatch from fcb676a to install udp binary correctly by @smooge in openembedded#449 logfile: exhance internal dlt logging by introducing size limits by @danielweber2018 in openembedded#369 dlt-logd-converter: fixes android 12 compilation by @sebastienraillet in openembedded#445 dlt-logd-converter: Fix getting log level from log msg by @RobinChenJP in openembedded#456 house-keeper: remove infinite wait by @alexmohr in openembedded#438 cmake: remove duplicated option message by @minminlittleshrimp in openembedded#454 Android: Add new feature in Android bp by @minminlittleshrimp in openembedded#461 dlt_multiple_files: remove superfluous mode bits and add header file to header list by @minminlittleshrimp in openembedded#462 dlt-user: fix crash with certain strings by @alexmohr in openembedded#463 Signed-off-by: Gianfranco Costamagna <[email protected]> Signed-off-by: Gianfranco Costamagna <[email protected]> Signed-off-by: Khem Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.