Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvpx: remove explicit armv5 and armv6 support #764

Closed
wants to merge 1 commit into from
Closed

libvpx: remove explicit armv5 and armv6 support #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions meta-oe/recipes-multimedia/webm/libvpx_1.13.1.bb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ BUILD_LDFLAGS += "-pthread"
export CC
export LD = "${CC}"

VPXTARGET:armv5te = "armv5te-linux-gcc"
VPXTARGET:armv6 = "armv6-linux-gcc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it doesn't build anymore, can you add COMPATIBLE_HOST restriction to indicate that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wasn't completely precise. The recipe fails to build for these targets in case the VPXTARGET variable is set to the specific toolchain name. In case the fallthrough generic-gnu value is used (like it is used for the other arch's), the recipe still builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then please update the commit message in the commit itself which currently has only the summary (not PR description) to make it more clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

VPXTARGET:armv7a = "${@bb.utils.contains("TUNE_FEATURES","neon","armv7-linux-gcc","generic-gnu",d)}"
VPXTARGET ?= "generic-gnu"

Expand Down