Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Implement eth_subscribe('syncing') #10080

Closed
amaury1093 opened this issue Dec 18, 2018 · 2 comments · Fixed by #10311 or #10312
Closed

Implement eth_subscribe('syncing') #10080

amaury1093 opened this issue Dec 18, 2018 · 2 comments · Fixed by #10311 or #10312
Assignees
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@amaury1093
Copy link
Contributor

Didn't find this in the issues, so posting it here.

Before filing a new issue, please provide the following information.

  • Parity Ethereum version: 2.3.0
  • Operating system: MacOS
  • Installation: homebrew
  • Fully synchronized: yes
  • Network: ethereum / ropsten / kovan / all
  • Restarted: yes

Repro:
create a WS connection and send {"id":2,"jsonrpc":"2.0","method":"eth_subscribe","params":["syncing"]}

Expected:
works

Actual:

{"jsonrpc":"2.0","error":{"code":-32000,"message":"This request is not implemented yet. Please create an issue on Github repo."},"id":2}
@Tbaut
Copy link
Contributor

Tbaut commented Dec 19, 2018

This issue got spotted thanks to Fether but it also happens on full nodes.

@Tbaut Tbaut added P5-sometimesoon 🌲 Issue is worth doing soon. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. labels Dec 19, 2018
@tomusdrw
Copy link
Collaborator

It was intentionally not implemented, cause the definition of "syncing" is a bit vague :) I guess we should make it work using is_major_sync heuristic: on every block import check is_major_importing and trigger the notification if the flag flips.

@5chdn 5chdn added this to the 2.3 milestone Jan 2, 2019
@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@axelchalon axelchalon self-assigned this Jan 31, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019
@axelchalon axelchalon reopened this Mar 5, 2019
@axelchalon axelchalon assigned seunlanlege and unassigned axelchalon Mar 5, 2019
@soc1c soc1c modified the milestones: 2.5, 2.6 Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M6-rpcapi 📣 RPC API. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
7 participants