Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to flutter 3.3 or 3.7/3.8 #3585

Closed
monsieurtanuki opened this issue Jan 16, 2023 · 7 comments
Closed

Upgrade to flutter 3.3 or 3.7/3.8 #3585

monsieurtanuki opened this issue Jan 16, 2023 · 7 comments
Assignees
Labels
✨ enhancement New feature or request

Comments

@monsieurtanuki
Copy link
Contributor

Problem

We had problems with flutter 3.3 (September 2022?) and decided to stay on 3.0.5.
That's getting ridiculous as a new flutter version arrives within 2 weeks.

Proposed solution

I can't remember what was wrong with 3.3, and I don't recommend to jump to 3.7 asap, but at least we should upgrade to the latest stable 3.3 version.
For that we need to have a clear view:

  • which bugs prevented us from upgrading to early 3.3, months ago?
  • are those bugs still present with the latest 3.3?
  • is there something we could change on our code in order to work with 3.3, and potentially 3.7?
@monsieurtanuki monsieurtanuki added the ✨ enhancement New feature or request label Jan 16, 2023
@Sudhanva-Nadiger
Copy link
Contributor

Sudhanva-Nadiger commented Jan 17, 2023

Hi @monsieurtanuki
Just checked whether app will run in latest stable version(3.3.10) for windows ! Initially it gave error :(, then i did flutter clean and flutter pub get . and the app ran successfully 🤩

@AshAman999
Copy link
Member

Just checked whether app will run in latest stable version(3.3.10) for windows! Initially, it gave error :(, then I did flutter clean and flutter pub get. and the app ran successfully 🤩

Hello @Sudhanva-Nadiger !!!

The point was it wasn't related to building the app with the latest flutter, but the cause of some unintended behavior with it,
Will need some more research then just building the app with latest flutter

@Sudhanva-Nadiger
Copy link
Contributor

Sudhanva-Nadiger commented Jan 17, 2023

I dono about that ! When I was going through the issue it was saying about some rendering error,smooth scrolling and some text field error ! Those things have been solved in newer version i suppose!

@monsieurtanuki
Copy link
Contributor Author

From what I read in the issues (open+close), we experienced those problems with 3.3:

I suggest we upgrade to 3.3.10 (2022/12/15), with a specific care about those issues - trying to reproduce them for instance.
We cannot stay forever in 3.0.5; if needed we'll have to find workarounds or accept minor cosmetic bugs.

I don't know when the next Smoothie release is expected (where most background bugs should be fixed), but anyway we should upgrade at the latest just after the next Smoothie release.

@monsieurtanuki monsieurtanuki self-assigned this Jan 18, 2023
@AshAman999
Copy link
Member

I think we are good to go to upgrade the flutter version,
in the worst case we can always revert back !

@monsieurtanuki
Copy link
Contributor Author

@AshAman999 Thank you for your message!
That said, assuming that v4.3.0 has important enough fixes and new features, we would be better off releasing it in 3.0.5 first.
And then focus on the flutter 3.3 upgrade and its potential known side-effects.

@monsieurtanuki
Copy link
Contributor Author

For the record it looks like with flutter 3.7 mac users now need macos 12 at least.
Which is problematic on an 11-years-old mac book.
Let me repeat myself: I HATE apple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Development

No branches or pull requests

4 participants