Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invisible loading animation for pictures #5641

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Sep 28, 2024

Hi everyone!

There was an issue with the loading animation effect not being visible on images.
It's now fixed + dark mode is fully supported

Screenshot 2024-09-28 at 02 43 05 Screenshot 2024-09-28 at 02 47 25

@g123k g123k self-assigned this Sep 28, 2024
@g123k g123k changed the title fix: Invisible loading animation fix: Invisible loading animation for pictures Sep 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 134 lines in your changes missing coverage. Please review.

Project coverage is 6.87%. Comparing base (4d9c7fc) to head (7114689).
Report is 336 commits behind head on develop.

Files with missing lines Patch % Lines
...pp/lib/pages/product/common/product_list_page.dart 0.00% 69 Missing ⚠️
.../lib/pages/product/product_image_gallery_view.dart 0.00% 54 Missing ⚠️
...p/lib/generic_lib/widgets/images/smooth_image.dart 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5641      +/-   ##
==========================================
- Coverage     9.54%   6.87%   -2.68%     
==========================================
  Files          325     402      +77     
  Lines        16411   21316    +4905     
==========================================
- Hits          1567    1466     -101     
- Misses       14844   19850    +5006     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 3c8c299 into openfoodfacts:develop Sep 30, 2024
6 checks passed
@teolemon
Copy link
Member

thx @g123k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants