-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pretty-quick by a different tool #11823
Comments
I don't think that we should install pre-commit hooks by default. It should be up to the developer when to run linters. And we have CI as last line of defense. You can integrate with your IDE or you may only change the README file and don't need to run any validations. |
The pre commit hook was added here : e0b4022 |
Something on my list of things to do when I have time (retire?) was to create a smart hook that only runs relevant linters depending on what files are changed. Also specs (eg rspec for But that's just my personal preference; I agree that it should be user-configurable. Maybe that's what Husky is for? |
I opened this #11824 which replaced |
Hi! I came across thie repo in the pretty-quick pr (prettier/pretty-quick#165) and would just like to let you know that @JounQin has taken over the project and has released pretty-quick v4, which adds support for prettier v3. related comments:
|
What we should change and why (this is tech debt)
As first noted here #11165 (comment)
pretty-quick
is not maintained anymore.So we should replace it by something else, maybe https:/lint-staged/lint-staged is was mentioned a few times here : prettier/pretty-quick#164
In the mean time we should not upgrade
prettier
Context
This came up here #11165
Impact and timeline
The text was updated successfully, but these errors were encountered: