Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export positions with virtual sites by default #1078

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Export positions with virtual sites by default #1078

merged 1 commit into from
Oct 15, 2024

Conversation

mattwthompson
Copy link
Member

Description

Resolves #1077, reversing one (important) default value in #1074 but not changing the overall design

Checklist

  • Add tests
  • Lint
  • Update docstrings

@mattwthompson mattwthompson added this to the 0.4 milestone Oct 11, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (69b8955) to head (c447f1c).
Report is 2 commits behind head on develop.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review October 15, 2024 14:41
@mattwthompson mattwthompson merged commit 672643a into develop Oct 15, 2024
21 checks passed
@mattwthompson mattwthompson mentioned this pull request Oct 15, 2024
Closed
@mattwthompson mattwthompson deleted the fix-1074 branch October 16, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mattwthompson