Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pyarrow optional #113

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Make pyarrow optional #113

merged 2 commits into from
Apr 11, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Apr 10, 2024

We should aim to keep the inference part of the library as lightweight as possible. Pyarrow is basically only needed for fitting, i.e. for dataset construction and usage.

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Merging #113 (cbebddc) into main (7a51b4f) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 76.47%.

Additional details and impacted files

@mattwthompson
Copy link
Member

I think this would be a good change - lighter user environments are nice

@lilyminium
Copy link
Collaborator Author

Thanks Matt! Yeah, I think this'll help a bit, pyarrow pulls in a lot of helper libraries too.

@lilyminium lilyminium merged commit 72d52f7 into main Apr 11, 2024
62 checks passed
@lilyminium lilyminium deleted the make-pyarrow-optional branch April 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants