Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI warnings #147

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Fix CI warnings #147

merged 10 commits into from
Oct 18, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Oct 17, 2024

Fixes #148

  • CI is getting warnings about using macOS-latest and Mambaforge; this PR upgrades them both. It also removes some Py3.12 exclusions that I think are ready to go now.
  • It also switches over to use conda-forge/dgl which is a fully featured install that includes torchdata. Previously that was causing an ImportError on torchdata, which triggered the pytest.importorskip(dgl) condition of some tests.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (1d7e4ff) to head (1cbe6bd).
Report is 2 commits behind head on main.

Additional details and impacted files

@lilyminium lilyminium merged commit 4347b29 into main Oct 18, 2024
62 of 116 checks passed
@lilyminium lilyminium deleted the update-ci branch October 18, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytest not collecting all tests
2 participants