Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domains, versioning, and tests #54

Merged
merged 9 commits into from
Aug 25, 2023
Merged

Add domains, versioning, and tests #54

merged 9 commits into from
Aug 25, 2023

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Aug 25, 2023 •
edited
Loading

Fixes #

Changes made in this Pull Request:

  • This adds warnings/errors for if a molecule falls outside a training set
  • Also adds versioning to the Model in case we change it again in the future

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #54 (6bdbca6) into main (43f3d8a) will increase coverage by 0.20%.
The diff coverage is 93.44%.

Additional details and impacted files

@lilyminium lilyminium merged commit db76183 into main Aug 25, 2023
64 checks passed
@lilyminium lilyminium deleted the add-domains-and-versions branch August 25, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilyminium @codecov-commenter