Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing for DGL 2.0 #79

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Fix typing for DGL 2.0 #79

merged 5 commits into from
Feb 9, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Feb 9, 2024 •
edited
Loading

Fixes #78

I'm pretty sure this is a result of DGL updating to 2.0 -- first step is reproduction.

Changes made in this Pull Request:

  • Fixes typing

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@lilyminium lilyminium marked this pull request as draft February 9, 2024 03:54
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024 •
edited
Loading

Codecov Report

Merging #79 (262434d) into main (fd2d78f) will decrease coverage by 0.21%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@lilyminium lilyminium marked this pull request as ready for review February 9, 2024 05:19
@lilyminium lilyminium merged commit 869993d into main Feb 9, 2024
40 of 41 checks passed
@lilyminium lilyminium deleted the fix-int-typing branch February 9, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charge assignment failing on macos with DGL backend
2 participants
@lilyminium @codecov-commenter