Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioneer #86

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Update versioneer #86

merged 3 commits into from
Feb 12, 2024

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Feb 9, 2024

Part of #85

Changes made in this Pull Request:

  • Update versioneer for Python 3.12 compatibility
  • Try CI on Python 3.12 (hey, well, I tried!)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@mattwthompson mattwthompson mentioned this pull request Feb 9, 2024
@mattwthompson
Copy link
Member Author

No DGL on 3.12

@mattwthompson mattwthompson marked this pull request as ready for review February 9, 2024 14:52
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Merging #86 (9330eed) into main (e1e96bf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@mattwthompson
Copy link
Member Author

There's a chance that 0.28 already in the tree is 3.12 compatible, I'm not sure. I think other repos I updated were on something like 0.16

Copy link
Collaborator

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I don't think versioneer will officially support 3.12 until the as-yet-unreleased 0.30 -- I'll keep an eye out if/when it does.

@lilyminium lilyminium merged commit 494edb2 into main Feb 12, 2024
41 checks passed
@lilyminium lilyminium deleted the update-versioneer branch February 12, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants