This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #110
Solution
When react was upgraded from v16 to v17, nested form elements no longer fires onSubmit. LinkControl was originally a nested form inside its rich text editor, so this PR removes the form element.
facebook/react#20741
##BEFORE
Screen.Recording.2021-08-19.at.11.49.21.AM.mov
##AFTER
Screen.Recording.2021-08-19.at.3.07.55.PM.mov