[knx] Handle exceptions during initial read

[holgerfriedrich]

fixes #7239

Signed-off-by: Holger Friedrich [email protected]

[holgerfriedrich]

factored out from #12434

[lolodomo]

@jlaur : please take the lead to review this PR, your comments are more detailed than mine.

[holgerfriedrich]

@jlaur I had a closer look into the implementation of the Calimero library. The function called in the try block may throw more exceptions than declared,,,,

ProcessCommunicatior.read(...) declares KNXException, InterruptedException

but it may throw other exceptions as well:

readFromGroup declares InterruptedException and subclasses of KNXException -> may throw
IllegalStateException extends RuntimeException extends Exception if detached
InterruptedException extends Exception in case secure GO is interrupted
CancellationException extends IllegalStateException extends RuntimeException extends Exception in case secure GO is interrupted
KnxTimeoutException extends KnxException in case secure GO times out

extractGroupASDU -> may throw KnxIllegalArgumentException extends KnxRuntimeException extends RuntimeException extends Exception in case APDU length does not match configured data type
setdata -> may throw KnxIllegalArgumentException extends KnxRuntimeException extends RuntimeException extends Exception

createTranslator -> may throw
[IndexOutOfBoundsException extends RuntimeException extends Exception]
NumberFormatException extends IllegalArgumentException extends RuntimeException extends Exception DPT type cannot be parsed
KnxException no translator, other exceptions re-thrown as KnxException

DataUnitBuilder.extractASDU -> may throw KNXIllegalArgumentException extends RuntimeException extends Exception wrong APDU data

So I now changed the code do catch any exception.

The rationale behind it is as follows: any exception will end all scheduled reads, as the scheduled job ends. Catching exceptions and printing error messages is the approach, as it only skips the one faulty DP and continues for all others.
All exceptions which could be resolved with a retry should be handled in the first catch(KNXException) clause. Interruption is handled separately, as no log with stack trace is needed. All other stuff is printed as a warning, as I do not want to hide any problem.

[jlaur]

So I now changed the code do catch any exception. The rationale behind it is as follows: any exception will end all scheduled reads, as the scheduled job ends.
[....]

Thanks for following up on this. I think it's fine, since you are calling an external library you have no control over. So you need to encapsulate the risk of anything than can happen outside your boundary.

[jlaur]

Thanks for the fix.