[ecobee] Fix issue with UTC and local dates #14170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <[email protected]>
Signed-off-by: Mark Hilbush <[email protected]>
jlaur
reviewed
Jan 6, 2023
...cobee/src/main/java/org/openhab/binding/ecobee/internal/dto/thermostat/DateDeserializer.java
Outdated
Show resolved
Hide resolved
jlaur
changed the title
Signed-off-by: Mark Hilbush <[email protected]>
jlaur
reviewed
Jan 8, 2023
...ab.binding.ecobee/src/main/java/org/openhab/binding/ecobee/internal/handler/EcobeeUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Hilbush <[email protected]>
jlaur
approved these changes
Jan 8, 2023
|
Thanks. I appreciate your help getting this over the finish line! |
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Correctly handle UTC and local date/times * Eliminate use of Date class Signed-off-by: Mark Hilbush <[email protected]>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Correctly handle UTC and local date/times * Eliminate use of Date class Signed-off-by: Mark Hilbush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ecobee API returns all date/time fields formatted as "yyyy-MM-dd HH:mm:ss". Most of those date/times are in UTC time, however a couple are in local time. This PR correctly handles both cases by:
Reference: https://community.openhab.org/t/ecobee-binding-v2/97733/225
Signed-off-by: Mark Hilbush [email protected]