-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[comfoair] Extend UoM support, add semantic tags & update state descriptions #15167
Conversation
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Signed-off-by: Hans Böhm <[email protected]>
Some things are a bit unclear for me and maybe have to be adapted:
Any recommendations on these are welcome. |
Signed-off-by: Hans Böhm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Thanks @jlaur for the fast review and merge. Additionally, I forgot to update the changes on |
If you can create a small note about this in this section, it would probably be safest - just in case some users would be affected: |
…iptions (openhab#15167) * enable UoM for rpm values * support uom for non-hour time channels * add state options for frost setting * add data type for percentage * support DecimalType for QuantityType channels * support rfc2217 * improve state description for time channels * improve code style in DataTypes * remove unnecessary command type check * enable UoM for enthalpy timer Signed-off-by: Hans Böhm <[email protected]>
…iptions (openhab#15167) * enable UoM for rpm values * support uom for non-hour time channels * add state options for frost setting * add data type for percentage * support DecimalType for QuantityType channels * support rfc2217 * improve state description for time channels * improve code style in DataTypes * remove unnecessary command type check * enable UoM for enthalpy timer Signed-off-by: Hans Böhm <[email protected]> Signed-off-by: Matt Myers <[email protected]>
…iptions (openhab#15167) * enable UoM for rpm values * support uom for non-hour time channels * add state options for frost setting * add data type for percentage * support DecimalType for QuantityType channels * support rfc2217 * improve state description for time channels * improve code style in DataTypes * remove unnecessary command type check * enable UoM for enthalpy timer Signed-off-by: Hans Böhm <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
This PR provides following improvements to the comfoair binding:
ventilation#fanInRPM
andventilation#fanOutRPM
)