Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Support chaining transformations without an intersection symbol #17288

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 18, 2024

Depends on openhab/openhab-core#4353 (merged)

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/syntax-for-binding-transformations/157861/1

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Aug 18, 2024
@J-N-K J-N-K added the rebuild Triggers Jenkins PR build label Aug 18, 2024
Signed-off-by: Jimmy Tanagra <[email protected]>
@J-N-K J-N-K added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 18, 2024
@jimtng jimtng changed the title [http] Support transformation chaining without an intersection symbol [http] Support chaining transformations without an intersection symbol Aug 19, 2024
@jimtng jimtng marked this pull request as ready for review August 19, 2024 12:27
@jimtng jimtng requested a review from a team as a code owner August 19, 2024 12:27
@jimtng
Copy link
Contributor Author

jimtng commented Aug 20, 2024

The core functionality that this PR needs has been merged, and I've briefly tested the chaining functionality and it works.

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K added this to the 4.3 milestone Aug 20, 2024
@J-N-K J-N-K merged commit 5975a5b into openhab:main Aug 20, 2024
5 checks passed
@jimtng jimtng deleted the http-transform-list branch August 20, 2024 15:21
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
openhab#17288)

* [http] Support transformation chaining without an intersection symbol

Signed-off-by: Jimmy Tanagra <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
openhab#17288)

* [http] Support transformation chaining without an intersection symbol

Signed-off-by: Jimmy Tanagra <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
openhab#17288)

* [http] Support transformation chaining without an intersection symbol

Signed-off-by: Jimmy Tanagra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants