Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OH4 Tasks #3230

Closed
5 tasks
J-N-K opened this issue Dec 15, 2022 · 15 comments
Closed
5 tasks

OH4 Tasks #3230

J-N-K opened this issue Dec 15, 2022 · 15 comments

Comments

@J-N-K
Copy link
Member

J-N-K commented Dec 15, 2022

Need to be done in this order

Independent Changes

@J-N-K J-N-K pinned this issue Dec 15, 2022
@rkoshak
Copy link

rkoshak commented Dec 16, 2022

Maybe not appropriate to list it here (is there a similar issue for openhab-addons?), but shouldn't the Nashorn addon from the marketplace be brought in to the openhab-addons repo as part of OH 4? Then a decision would need to be made whether or not it should be automatically installed by default (like rrd4j) or not (I'd vote for not, assuming the porting of Blockly to JS Scripting is done before that.)

This seems like a great opportunity to split out Rules DSL into it's own add-on too. I'm not sure that's required for OH 4 though, but I think it would be a good idea.

@J-N-K
Copy link
Member Author

J-N-K commented Dec 16, 2022

Please note that there is also openhab/openhab-distro#1316 which already covers some of your points. I had a quick look at refactoring DSL rules to an add-on, but that requires a bit more work.

@wborn wborn added this to the 4.0 milestone Dec 18, 2022
@florian-h05
Copy link
Contributor

assuming the porting of Blockly to JS Scripting is done before that

I expect it to be — I created the code that automatically switches from Nashorn to GraalJS by modifying the MIME type and ported the logging blocks and @stefan-hoehn ported another block categories two weeks ago. You can have a look at https:/stefan-hoehn/openhab-webui/commits/blockly_jsscripting. After the 3.4.0 Stable Release, I‘ve to take care of a few things in openhab-js but I am planning to ported a few other blocks over the holidays.

@cweitkamp
Copy link
Contributor

cweitkamp commented Dec 18, 2022

In the past we tried to use GitHub Projects to keep track of issues and pull requests for separate OH versions ( see https:/orgs/openhab/projects?type=classic ). I am not sure if someone tracked and kept it up to date all the time but maybe we should take a second look into the tool. One advantage is that it can be configured globally to be used with several repositories.

@florian-h05
Copy link
Contributor

Sound like a good suggestion @cweitkamp and IMO would make our lives much easier as we have one central place to track everything that‘s important.

@J-N-K
Copy link
Member Author

J-N-K commented Dec 18, 2022

I already addd a project. Can you see and edit that?

@J-N-K J-N-K unpinned this issue Dec 18, 2022
@florian-h05
Copy link
Contributor

florian-h05 commented Dec 18, 2022

I can see and edit the project: I‘ve updated the view to include the repo and labels, but to hide assignees.
I‘ve also added a second view: a Kanban.

@cweitkamp
Copy link
Contributor

Yes, I can see it an edit it.

@stefan-hoehn
Copy link
Contributor

stefan-hoehn commented Dec 19, 2022

@florian-h05 Should we put the our blockly jscripting issue to the board as well and add all the tasks that need to be done?

@florian-h05
Copy link
Contributor

florian-h05 commented Dec 19, 2022

@stefan-hoehn
Yes, we should add this. But IMO we should create a new issue in webui, reference the old PR and close the old PR. Discussing at a PR is not so great IMO.
In the new issue we can also add todos and describe our approach.

@wborn
Copy link
Member

wborn commented Dec 19, 2022

@kaikreuzer can you make the project public in the settings?

Changing the visibility is restricted to owners when you create one:

Screenshot from 2022-12-19 16-13-51

@digitaldan
Copy link
Contributor

@kaikreuzer can you make the project public in the settings?

Done.

@kaikreuzer
Copy link
Member

Ok, you were quicker - I was just about to do it. 😉

@wborn wborn removed this from the 4.0 milestone Dec 19, 2022
@J-N-K
Copy link
Member Author

J-N-K commented Dec 22, 2022

Since we track it in the project -> Closed.

@J-N-K J-N-K closed this as completed Dec 22, 2022
@florian-h05
Copy link
Contributor

Why is the project closed??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants