Tweak ScriptedRuleProvider slightly #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just extend AbstractProvider so that it doesn't need to re-implement managing listeners Signed-off-by: Cody Cutrer <[email protected]>
there's nothing that says ManagedProvider has to be backed by storage, just that they should be able to add and remove elements Since that's exactly what ScriptedRuleProvider does, might as well have it conform to the interface. Signed-off-by: Cody Cutrer <[email protected]>
wborn
changed the title
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* tweak ScriptedRuleProvider slightly just extend AbstractProvider so that it doesn't need to re-implement managing listeners Signed-off-by: Cody Cutrer <[email protected]> * have ScriptedRuleProvider implement ManagedProvider there's nothing that says ManagedProvider has to be backed by storage, just that they should be able to add and remove elements Since that's exactly what ScriptedRuleProvider does, might as well have it conform to the interface. Signed-off-by: Cody Cutrer <[email protected]> GitOrigin-RevId: f0875a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend AbstractProvider so that it doesn't need to re-implement managing listeners, and have it implement ManagedProvider