Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getAllStatesSince() and getAllStatesBetween() to PersistenceExtensions #3466

Merged
merged 1 commit into from
May 27, 2023
Merged

Add getAllStatesSince() and getAllStatesBetween() to PersistenceExtensions #3466

merged 1 commit into from
May 27, 2023

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 19, 2023

This would open up a lot more possibilities on what can be done with persistence data.

@jimtng jimtng requested a review from a team as a code owner March 19, 2023 23:43
@jimtng jimtng closed this Apr 26, 2023
@J-N-K
Copy link
Member

J-N-K commented May 20, 2023

@jimtng Why did you close this?

@J-N-K J-N-K mentioned this pull request May 20, 2023
Merged
@jimtng jimtng reopened this May 21, 2023
J-N-K
J-N-K approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@kaikreuzer kaikreuzer merged commit 6bb15b8 into openhab:main May 27, 2023
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature of the Core label May 27, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone May 27, 2023
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@jimtng @splatch
Add getAllStatesSince() and getAllStatesBetween() to PersistenceExten…
31503ce 
…sions (openhab#3466)

Signed-off-by: Jimmy Tanagra <[email protected]>
GitOrigin-RevId: 6bb15b8
@jimtng jimtng mentioned this pull request Aug 7, 2023
Merged
ccutrer pushed a commit to openhab/openhab-jruby that referenced this pull request Aug 8, 2023
@jimtng
Support all_states_since and all_states_between persistence methods (#…
b6899b1 
…105)

openhab/openhab-core#3466

Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng deleted the persistence-allstates branch August 21, 2023 23:05
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/how-to-calculate-averagesince-without-null-values/149210/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jimtng @J-N-K @openhab-bot @kaikreuzer