Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong ready marker in ScriptEngineFactoryBundleTracker #3683

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Fix wrong ready marker in ScriptEngineFactoryBundleTracker #3683

merged 3 commits into from
Jul 6, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 3, 2023

Fixes #3676

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 3, 2023
@lolodomo lolodomo mentioned this pull request Jul 5, 2023
Closed
J-N-K added 2 commits July 5, 2023 20:31
@J-N-K
improve logging
2ab77f5 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K
fix ready marker handling
62e4921 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K marked this pull request as ready for review July 5, 2023 19:23
@J-N-K J-N-K requested a review from a team as a code owner July 5, 2023 19:23
kaikreuzer
kaikreuzer approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 6a0b268 into openhab:main Jul 6, 2023
2 checks passed
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jul 6, 2023
@J-N-K J-N-K deleted the bug-scriptenginefactorytracker branch July 6, 2023 06:26
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@J-N-K @splatch
Fix wrong ready marker in ScriptEngineFactoryBundleTracker (openhab#3683
ebe74a3 
)

* Fix wrong ready marker in ScriptEngineFactoryBundleTracker
* fix ready marker handling

Signed-off-by: Jan N. Klug <[email protected]>
GitOrigin-RevId: 6a0b268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Rules refuse to load at startup due to jars in addons folder
2 participants
@J-N-K @kaikreuzer