Fix translation of label for system:addons service

[lolodomo]

The i18n file containing this label is in org.openhab.core bundle.

Fix openhab/openhab-webui#1669

Signed-off-by: Laurent Garnier [email protected]

[lolodomo]

It looks like all new PRs build is failing in integration tests:

[INFO] --- bnd-testing:7.0.0:testing (default) @ org.openhab.core.tests ---
[INFO] Matching glob *
[INFO] Testing /var/jenkins_home/workspace/PR-openHAB-Core/itests/org.openhab.core.tests/itest.bndrun:
[INFO] Verification of feature openhab.tp-commons-net/4.3.0.SNAPSHOT succeeded
[INFO] Verification of feature openhab.tp-gson/4.3.0.SNAPSHOT succeeded
[INFO] Verification of feature openhab-core-base/4.3.0.SNAPSHOT succeeded
[INFO] Verification of feature openhab.tp-hivemqclient/4.3.0.SNAPSHOT succeeded
     [java] Error: Could not find or load main class 'self';
     [java] Caused by: java.lang.ClassNotFoundException: 'self';
[INFO] 1 Error(s)
[ERROR] Error   : Exit code remote process 1: /var/jenkins_home/tools/hudson.model.JDK/OpenJDK_17/bin/java -Xms2G -Xmx4G -XX:+UseG1GC -XX:+ExplicitGCInvokesConcurrent -XX:+ParallelRefProcEnabled -XX:+UseStringDeduplication -Dhudson.model.DirectoryBrowserSupport.CSP="default-src 'self'; img-src 'self' data: *; style-src 'self' 'unsafe-inline'; child-src 'self'; frame-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; frame-ancestors 'self'" -Djavamelody.application-name=jenkins -cp /var/jenkins_home/workspace/PR-openHAB-Core/itests/org.openhab.core.tests/target/test/tmp/testing/itest/cnf/cache/7.0.0/bnd-cache/biz.aQute.launcher/biz.aQute.launcher.pre.jar -Dlauncher.properties=/var/jenkins_home/workspace/PR-openHAB-Core/itests/org.openhab.core.tests/target/test/tmp/testing/itest/generated/launch420501016096256862.properties -Djdk.util.zip.disableZip64ExtraFieldValidation=true -Dorg.osgi.service.http.port=46159 --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.desktop/java.awt.font=ALL-UNNAMED --add-opens=java.naming/javax.naming.spi=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport.tcp=ALL-UNNAMED -ea -Dlauncher.runpath=/var/jenkins_home/workspace/PR-openHAB-Core/itests/org.openhab.core.tests/target/test/tmp/testing/itest/cnf/cache/7.0.0/org.openhab.core.bom.runtime-index/org.eclipse.osgi-3.18.0.v20220516-2155.jar,/var/jenkins_home/workspace/PR-openHAB-Core/itests/org.openhab.core.tests/target/test/tmp/testing/itest/cnf/cache/7.0.0/bnd-cache/biz.aQute.launcher/biz.aQute.launcher-7.0.0.jar aQute.launcher.pre.EmbeddedLauncher

@wborn : any idea if something remains to be done after the switch from 4.2 to 4.3 ?

[lolodomo]

Locally on my Windows PC, the integration tests compile properly. So no idea what's going on.

[wborn]

[java] Error: Could not find or load main class 'self';
[java] Caused by: java.lang.ClassNotFoundException: 'self';

This was caused by a Java option only used on Jenkins. I disabled it for now so it doesn't cause build issues, but the side effect is that CSS is not applied to the static analysis results when viewed in Jenkins. The parameter didn't propagate into the PR build environment when it was still build on an agent instead of the built-in node.

[J-N-K]

Why are the i18n properties not in the bundle that provides the service?

[lolodomo]

Because config parameters are also in this bundle?
https:/openhab/openhab-core/blob/main/bundles/org.openhab.core/src/main/resources/OH-INF/config/addons.xml

[holgerfriedrich]

LGTM