Extend HistoricItem to work with Instant instead of ZonedDateTime #4384
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new
default
method to the HistoricItem interface, to get the timestamp asInstant
.The most areas using the
HistoricItem
must transform the internalInstant
to aZonedDateTime
(e.g. all the persistence implementations) or need to transform the returnedZonedDateTime
to anInstant
(e.g. see the below).So i my mind it does make sense to use a
Instant
here and not transform the data.The link to the persistence implementations above does show the changes needed to the addons.
Signed-off-by: Jörg Sautter [email protected]