[rest] Persistence: Optionally add current Item state to response #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-h05
force-pushed
the
rest-persistence-itemstate
branch
from
5254735
to
47a030f
Compare
…ponse This new optional parameter gives the UI additional possibilities for charts. E.g. it is now possible to display a bar chart with monthly energy consumption, where the consumption is only persisted at the end of the month, that includes the data from this month. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
force-pushed
the
rest-persistence-itemstate
branch
from
47a030f
to
9933999
Compare
|
I can totally understand why this param makes sense. These are the situations where you want to have all the information presented and where the data to be shown has not been persisted yet (for a reason), so you start developing you own specific implementation and work around. Therefore, your extension is very welcome! Very good idea. |
Signed-off-by: Florian Hotze <[email protected]>
kaikreuzer
approved these changes
Oct 9, 2024
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 10, 2024
Refs openhab/openhab-core#4394. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Oct 10, 2024
Refs openhab/openhab-core#4394. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
to openhab/openhab-webui
that referenced
this pull request
Oct 10, 2024
…ault (#2805) Refs openhab/openhab-core#4394. Signed-off-by: Florian Hotze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new query param
itemStateto the GET/rest/persistence/items/{itemname}endpoint.This new parameter allows to add the current Item state to the data returned from persistence, which is a huge improvement for charts in the UI:
There are two special cases where the Item state is not added with the current time to the response:
boundaryquery param is also set to true and a state was already added to the requested end time, there is no need to include the current Item state as there already is a state at the end of the time range.