Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release build broken due to SAT using Java 17 #1540

Closed
kaikreuzer opened this issue May 21, 2023 · 4 comments · Fixed by openhab/static-code-analysis#451
Closed

Release build broken due to SAT using Java 17 #1540

kaikreuzer opened this issue May 21, 2023 · 4 comments · Fixed by openhab/static-code-analysis#451
Labels

Comments

@kaikreuzer
Copy link
Member

Our release build is broken since May 17: https://ci.openhab.org/view/Sandbox/job/sandbox-openhab4-release/

It runs the unleash steps with Java 11 and complains that the SAT classes were compiled with Java 17 (which is true since we released SAT 0.14.0).
I'm not sure why SAT classes are loaded here at all, since we use -skipChecks=true here.

@kaikreuzer
Copy link
Member Author

kaikreuzer commented May 21, 2023

What I have figured out so far is the fact that the issue comes by loading the SAT extension (not only the plugin) in the build.

@kaikreuzer
Copy link
Member Author

@pfink & @wborn: Would you have any good idea how we could resolve this issue?

@wborn
Copy link
Member

wborn commented May 22, 2023

Apparently you can't move extensions into a profile (see Maven Model) or disable them in some other way. So perhaps the easiest way to workaround it is to compile SAT using Java 11 again until #1475 is resolved.

@kaikreuzer
Copy link
Member Author

Hm, I thought that SAT already uses Java 17 features as it has been updated - but it indeed still compiles nicely with Java 11. I have created openhab/static-code-analysis#451 to do this change.
We will have to release a new version 0.15.0 as we are not able to replace the version on Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants