added channel types meter_kvar & meter_kvarh #1604
Conversation
Signed-off-by: Boris Fierlings <[email protected]>
| @@ -522,7 +532,7 @@ | |||
| <channel-type id="meter_kwh"> | |||
| <item-type>Number</item-type> | |||
| <label>Energy Consumption</label> | |||
| <description>Indicates the energy consumption (kWh)</description> | |||
| <description>Indicates the instantaneous energy consumption (kWh)</description> | |||
There was a problem hiding this comment.
For me, this is wrong - you don't have instantaneous energy consumption measured in watt-hours. Energy consumption is measured in Wh - but instantaneous power consumption is measures in watts.
I'm not sure how this links to the ZWave data definition and how that is applied to this channel, but fundamentally it's not correct to add instantaneous here and call it kWh.
There was a problem hiding this comment.
You are right. Togehter with energy consumption there is rarely used "instantaneous" but often "active" in opposite to the reactive and aparent energy consumption. So we can leave it as energy consumption or change to active energy consumption.
| <!-- Energy - Power Consumption --> | ||
| <channel-type id="meter_kvar"> | ||
| <item-type>Number</item-type> | ||
| <label>Electric Power Consumption</label> |
There was a problem hiding this comment.
Suggest to use consistent naming here - you added "Energy Consumption" above but "Electric Power Consumption" here. Either use "Electric" in both or neither.
There was a problem hiding this comment.
You are right again. As the "Electric" is not only in "Electric Power Consumption", but also in "Electric Current", it should be "Electric Energy Consumption". Sorry for that.
Signed-off-by: Boris Fierlings <[email protected]>
BorisFierlings
force-pushed
the
BorisFierlings-patch-2
branch
from
fce18c9
to
ee5241e
Compare
|
Sorry for beeing off that long time. I've done the changes as suggested. |
Added channel types meter_kvar & meter_kvarh. Will be needed for updated Qubino smart meter database defintion.
Signed-off-by: Boris Fierlings [email protected]