Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invokeAsync does not handle NullPointerException #42

Closed
RongtongJin opened this issue Jan 6, 2020 · 0 comments · Fixed by #43
Closed

Fix invokeAsync does not handle NullPointerException #42

RongtongJin opened this issue Jan 6, 2020 · 0 comments · Fixed by #43
Labels
enhancement enhancement

Comments

@RongtongJin
Copy link
Contributor

RongtongJin commented Jan 6, 2020 •
edited
Loading

Now we use invokeAsync in this way in dledger
https:/openmessaging/openmessaging-storage-dledger/blob/2450e39933931afb10d5eea47f55cdaa78973f11/src/main/java/io/openmessaging/storage/dledger/DLedgerRpcNettyService.java#L124-L127
if invokeAsync method timeout, there will be a thread to invoke the callback and responseFuture.getResponseCommand() return null, so a NullPointerException will be thrown.
we should deal with this situation when invokeAsync method timeout
@RongtongJin RongtongJin mentioned this issue Jan 6, 2020
Merged
@RongtongJin RongtongJin added the enhancement enhancement label Jan 6, 2020
vongosling added a commit that referenced this issue Jan 10, 2020
@vongosling
Merge pull request #43 from RongtongJin/fix_rpx_exception_handling
3adca38 
[ISSUE #42] Fix rpc module null pointer exception handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #42] Fix rpc module null pointer exception handling RongtongJin/openmessaging-storage-dledger
1 participant
@RongtongJin