Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slash and password copy #72

Merged
merged 4 commits into from
Jun 24, 2019
Merged

fix: slash and password copy #72

merged 4 commits into from
Jun 24, 2019

Conversation

DmitryEfimenko
Copy link
Member

Copy link
Contributor

@abashmak abashmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password feature works. Slash bug still present (both in new category and new item forms)

@DmitryEfimenko
Copy link
Member Author

fixes are in. run yarn before building and testing

@abashmak
Copy link
Contributor

One comment: after clicking on a URL to go to a site, then coming back to the application, the '/' shortcut key no longer puts the focus in the search bar. It's not a huge deal, but might be good to investigate why.

@DmitryEfimenko
Copy link
Member Author

I think the issue with the "/" has been there since we've introduced copying things to clipboard because it's an issue with 3rd party library. I opened a new issue there.

I'd say thing PR can be merged. I'll let you do it though.

@abashmak abashmak merged commit 9dfb2f5 into master Jun 24, 2019
@DmitryEfimenko DmitryEfimenko deleted the feature/bugs branch April 5, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic copy on URL click Use of '/' character in URL fields
2 participants