Make CreateFileVisitor less opaque by returning if it changed the value #4476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Changed
CreateFileVisitor
to returnSearchResult.found(sourceFile)
rather thansourceFile
if it updates theshouldCreate
boolean.What's your motivation?
To allow the visitor to be more easily used in precondition checks - it is currently used as a type of precondition in scanner recipes but is currently alway alone - e.g., when doing an
.and
it will return if any visitor returns thetree
unchanged which this visitor always does. Currently you don't know if the visitor found the file or not without checking an external variable.Have you considered any alternatives or workarounds?
Yes, I could wrap the visitor, but I don't see any downside to the visitor exposing if it made a change or not.
Checklist