Add ResolutionEventListener#downloadMetadataSuccess to communicate long download times to consumers of MavenPomDownloader
#4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to consumers of MavenPomDownloader
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-core/src/main/java/org/openrewrite/InMemoryExecutionContext.java
Outdated
Show resolved
Hide resolved
rewrite-core/src/main/java/org/openrewrite/scheduling/WatchableExecutionContext.java
Outdated
Show resolved
Hide resolved
…ntext.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…eExecutionContext.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Maybe we should put this on |
rewrite-maven/src/main/java/org/openrewrite/maven/MavenExecutionContextView.java
Outdated
Show resolved
Hide resolved
bryceatmoderne
changed the title
ExecutionContext#getOnDownload to communicate long download times to consumers of MavenPomDownloaderMavenExecutionContextView#getOnDownloaded to communicate long download times to consumers of MavenPomDownloader
…onContextView.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ite/rewrite into add-executioncontext-ondownload
|
you should also include |
After looking into this, |
bryceatmoderne
changed the title
MavenExecutionContextView#getOnDownloaded to communicate long download times to consumers of MavenPomDownloaderResolutionEventListener#downloadMetadataSuccess to communicate long download times to consumers of MavenPomDownloader
sambsnyd
requested changes
Oct 11, 2024
Comment on lines
+606
to
+607
| ctx.getResolutionListener() | ||
| .downloadSuccess(resolvedGav, containingPom, Duration.ofNanos(nanos)); |
There was a problem hiding this comment.
So the old, durationless event type still exists but will now never be called? That isn't great. If the old event is still going to exist it should continue to be called.
There was a problem hiding this comment.
I would prefer to remove the old event under the assumption only Moderne is consumers of it. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Long download times for small files such as
maven-metadata.xmlcan indicate network latency issues to internal artifactories. This PR introducesResolutionEventListener#downloadMetadataSuccessas a method to relay download times to consumers ofMavenPomDownloaderwhere they optional log warnings to assist troubleshooting long recipe runs and time outs.What's your motivation?
These changes are intended to assist in troubleshooting recipe run execution time outs.
Anything in particular you'd like reviewers to focus on?
No.
Anyone you would like to review specifically?
@pstreef @timtebeek
Have you considered any alternatives or workarounds?
Currently recorded metrics do not provide file level granularity and doing so would be prohibitively expensive WRT cardinality.
Any additional context
No.
Checklist