Apply add dependency correctly, taking aggregating poms into account #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies when they are used as parent
Laurens-W
commented
Oct 18, 2024
| return maven; | ||
| } | ||
|
|
||
| if (!getResolutionResult().getPom().getModules().isEmpty() |
There was a problem hiding this comment.
Haven't fully got this logic sorted, will continue on Monday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Introduce a mechanism to know which modules an aggregating pom applies to in order to prevent unnecessarily adding dependencies to aggregating poms
Anyone you would like to review specifically?
@timtebeek @sambsnyd
Any additional context
An aggregating pom could be a parent, when it's not there's no point in adding a dependency to it
Checklist