Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @zengyan-amazon as a Dashboards co-maintainer #2419

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

seanneumann
Copy link
Contributor

@seanneumann seanneumann commented Sep 26, 2022

Signed-off-by: Neumann [email protected]

Description

Adding Yan Zeng as Maintainer

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@seanneumann seanneumann requested a review from a team as a code owner September 26, 2022 17:25
@seanneumann seanneumann self-assigned this Sep 26, 2022
@ananzh ananzh added the docs Improvements or additions to documentation label Sep 26, 2022
@seanneumann seanneumann added v2.4.0 'Issues and PRs related to version v2.4.0' docs Improvements or additions to documentation and removed docs Improvements or additions to documentation labels Sep 26, 2022
@kavilla kavilla removed the v2.4.0 'Issues and PRs related to version v2.4.0' label Sep 26, 2022
@kavilla kavilla merged commit 8408b08 into main Sep 26, 2022
@kavilla kavilla deleted the neumann_add_maintainer_again branch September 26, 2022 18:25
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8408b082a1bd2471bf33190fb2368e55a0222942
# Push it to GitHub
git push --set-upstream origin backport/backport-2419-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2419-to-2.x.

ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
ananzh added a commit that referenced this pull request Nov 3, 2022
ananzh added a commit that referenced this pull request Nov 3, 2022
@AMoo-Miki AMoo-Miki added the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 5, 2022
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x docs Improvements or additions to documentation v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants