Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] Adding unit test coverage for Update data source management #2567

Merged
merged 8 commits into from
Oct 14, 2022

Conversation

mpabba3003
Copy link
Contributor

@mpabba3003 mpabba3003 commented Oct 13, 2022

Description

Adding unit test coverage for Update data source management

Issues Resolved

#2566

SCREENSHOTS

Screen Shot 2022-10-13 at 9 08 03 AM

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@mpabba3003 mpabba3003 requested a review from a team as a code owner October 13, 2022 16:05
@mpabba3003 mpabba3003 self-assigned this Oct 13, 2022
@mpabba3003 mpabba3003 added backport 2.x multiple datasource multiple datasource project v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #2567 (113c129) into main (9a55e0c) will increase coverage by 0.09%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
+ Coverage   66.72%   66.81%   +0.09%     
==========================================
  Files        3203     3207       +4     
  Lines       60940    61136     +196     
  Branches     9275     9313      +38     
==========================================
+ Hits        40662    40851     +189     
+ Misses      18058    18055       -3     
- Partials     2220     2230      +10     
Impacted Files Coverage Δ
...ents/edit_data_source/components/header/header.tsx 100.00% <ø> (ø)
...ts/update_password_modal/update_password_modal.tsx 95.83% <ø> (ø)
...c/components/edit_data_source/edit_data_source.tsx 91.83% <66.66%> (ø)
...rce/components/edit_form/edit_data_source_form.tsx 92.59% <100.00%> (ø)
src/plugins/data_source_management/public/mocks.ts 84.00% <100.00%> (+1.39%) ⬆️
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zengyan-amazon
zengyan-amazon previously approved these changes Oct 13, 2022
Copy link
Member

@zengyan-amazon zengyan-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mpabba3003 <[email protected]>
zengyan-amazon
zengyan-amazon previously approved these changes Oct 13, 2022
Signed-off-by: mpabba3003 <[email protected]>
@kristenTian kristenTian merged commit 115105a into opensearch-project:main Oct 14, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2567-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 115105a3c945dae4c2218caaeacaa854b2789afa
# Push it to GitHub
git push --set-upstream origin backport/backport-2567-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2567-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2567-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 115105a3c945dae4c2218caaeacaa854b2789afa
# Push it to GitHub
git push --set-upstream origin backport/backport-2567-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2567-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2022
* adding unit test cases for edit data source page

Signed-off-by: mpabba3003 <[email protected]>

* lint mock file

Signed-off-by: mpabba3003 <[email protected]>

* updating snapshot

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 115105a)
zhongnansu pushed a commit that referenced this pull request Oct 18, 2022
* adding unit test cases for edit data source page

Signed-off-by: mpabba3003 <[email protected]>

* lint mock file

Signed-off-by: mpabba3003 <[email protected]>

* updating snapshot

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 115105a)
zhongnansu pushed a commit that referenced this pull request Oct 19, 2022
* adding unit test cases for edit data source page

Signed-off-by: mpabba3003 <[email protected]>

* lint mock file

Signed-off-by: mpabba3003 <[email protected]>

* updating snapshot

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 115105a)
zhongnansu pushed a commit that referenced this pull request Oct 19, 2022
…) (#2589)

Signed-off-by: mpabba3003 <[email protected]>
(cherry picked from commit 115105a)

Co-authored-by: Manideep Pabba <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…nsearch-project#2567)

* adding unit test cases for edit data source page

Signed-off-by: mpabba3003 <[email protected]>

* lint mock file

Signed-off-by: mpabba3003 <[email protected]>

* updating snapshot

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

* updating CHANGELOG.MD

Signed-off-by: mpabba3003 <[email protected]>

Signed-off-by: mpabba3003 <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x multiple datasource multiple datasource project test:unit v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants