[Manual Backport 2.x][Discover] Add long numerals support (#5592) #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the usage of `pegjs` in tasks Signed-off-by: Miki <[email protected]> * [Discover] Add long numerals support * Add long numerals support to Discover tabular view, document view, inspector, hash-url, and share * Use a fork of `numeral-js` that supports long numerals * Patch `rison` to correctly serialize BigInts * Replace the uses of `withLongNumerals` with `withLongNumeralsSupport` to match the rest of the codebase and mark `withLongNumerals` for deprecation * Add `withLongNumeralsSupport` as an option to `code/public/http/fetch` * Add long numerals support to `UiSettingsClient` * Add long numerals support to `core/server/http/router` response handler * Add long numerals support to `RangeFilter` and `FilterBar` * Add long numerals support to `kuery/ast` * Introduce `OPENSEARCH_SEARCH_WITH_LONG_NUMERALS_STRATEGY` in `core/plugins/data/search` * Remove `ng-non-bindable` leftovers Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> (cherry picked from commit 10ae4ee) Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5798 +/- ##
==========================================
+ Coverage 67.04% 67.08% +0.03%
==========================================
Files 3294 3294
Lines 63370 63381 +11
Branches 10067 10079 +12
==========================================
+ Hits 42485 42517 +32
+ Misses 18440 18420 -20
+ Partials 2445 2444 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
changed the title
ashwin-pc
approved these changes
Feb 6, 2024
ZilongX
approved these changes
Feb 6, 2024
bandinib-amzn
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked 10ae4ee from #5592