Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual backport 2.x][MDS] Install Vega sample data (#6218) #6299

Merged

Conversation

huyaboo
Copy link
Member

@huyaboo huyaboo commented Mar 29, 2024

Manual backport of #6218 into 2.x

* Add data_source_name to sample data install

Signed-off-by: Huy Nguyen <[email protected]>

* Add unit test coverage

Signed-off-by: Huy Nguyen <[email protected]>

* Resolve CHANGELOG.md conflicts

Signed-off-by: Huy Nguyen <[email protected]>

* Refactor logic

Signed-off-by: Huy Nguyen <[email protected]>

* Remove newline

Signed-off-by: Huy Nguyen <[email protected]>

* Remove newline

Signed-off-by: Huy Nguyen <[email protected]>

* Add comments for spacing

Signed-off-by: Huy Nguyen <[email protected]>

* Update jsdoc

Signed-off-by: Huy Nguyen <[email protected]>

---------

Signed-off-by: Huy Nguyen <[email protected]>
(cherry picked from commit 8810f08)
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.31%. Comparing base (43440c3) to head (89f6e52).

Files Patch % Lines
...home/server/services/sample_data/data_sets/util.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #6299      +/-   ##
==========================================
+ Coverage   67.29%   67.31%   +0.01%     
==========================================
  Files        3342     3342              
  Lines       64757    64766       +9     
  Branches    10372    10375       +3     
==========================================
+ Hits        43581    43594      +13     
+ Misses      18655    18651       -4     
  Partials     2521     2521              
Flag Coverage Δ
Linux_1 ?
Linux_2 55.39% <100.00%> (+<0.01%) ⬆️
Linux_3 44.94% <0.00%> (-0.01%) ⬇️
Linux_4 35.30% <80.00%> (+0.09%) ⬆️
Windows_1 31.33% <0.00%> (-0.01%) ⬇️
Windows_2 55.35% <100.00%> (+<0.01%) ⬆️
Windows_3 44.95% <0.00%> (-0.01%) ⬇️
Windows_4 35.30% <80.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinruiba
Copy link
Member

xinruiba commented Mar 29, 2024

Thanks for this change.

In front of the PR title would you mind to add "[Manual Backport 2.x]"? Thanks

Also Changelog check failed but I don't think we need to include changefile.md changes in backport PR.

Folks, what do you think? @bandinib-amzn @ZilongX @Flyingliuhub @BionIT

@Flyingliuhub Flyingliuhub added the multiple datasource multiple datasource project label Mar 29, 2024
@Flyingliuhub
Copy link
Member

Flyingliuhub commented Mar 29, 2024

Thanks for this change.

In front of the PR title would you mind to add "[Manual Backport 2.x]"? Thanks

Also Changelog check failed but I don't think we need to include changefile.md changes in backport PR.

Folks, what do you think? @bandinib-amzn @ZilongX @Flyingliuhub @BionIT

backport doesn't need changelog if I understand correctly, and If a changelog was not included, you can add the tag 'skip-changelog' check.

@Flyingliuhub Flyingliuhub changed the title [MDS] Install Vega sample data (#6218) [manual backport 2.x][MDS] Install Vega sample data (#6218) Mar 29, 2024
@Flyingliuhub Flyingliuhub added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Mar 29, 2024
@bandinib-amzn
Copy link
Member

I am seeing commit history in PR overview. Please remove it. See other manual backport for reference.

@bandinib-amzn bandinib-amzn merged commit 1197a74 into opensearch-project:2.x Apr 1, 2024
69 of 92 checks passed
@huyaboo huyaboo deleted the backport/backport-6218-to-2.x branch April 18, 2024 00:16
@BionIT BionIT added the v2.14.0 label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants