Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discover options' location #7581

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Fix discover options' location #7581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f145330
fix discover options
abbyhu2000 Jul 30, 2024
fef9862
Changeset file for PR #7581 created/updated
opensearch-changeset-bot[bot] Jul 30, 2024
ee9f4af
fix discover options
abbyhu2000 Jul 30, 2024
3f43692
Merge branch 'style' of github.com:abbyhu2000/OpenSearch-Dashboards i…
abbyhu2000 Jul 30, 2024
624b105
update tooltip
abbyhu2000 Jul 30, 2024
642b318
Merge branch 'main' into style
abbyhu2000 Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7581.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
feat:
- Fix discover options' location ([#7581](https:/opensearch-project/OpenSearch-Dashboards/pull/7581))
12 changes: 7 additions & 5 deletions src/plugins/discover/public/application/components/chart/chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,16 +94,16 @@ export const DiscoverChart = ({
</div>
);

const toggleLabel = i18n.translate('queryEditor.collapse', {
defaultMessage: 'Toggle query editor',
const toggleLabel = i18n.translate('histogram.collapse', {
defaultMessage: 'Toggle histogram',
});

const toggle = (
<EuiToolTip content={toggleLabel}>
<EuiButtonIcon
aria-expanded={isCollapsed}
aria-label={toggleLabel}
data-test-subj="queryEditorCollapseBtn"
data-test-subj="histogramCollapseBtn"
onClick={() => setIsCollapsed(!isCollapsed)}
iconType={isCollapsed ? 'arrowRight' : 'arrowDown'}
iconSize={'s'}
Expand All @@ -124,9 +124,11 @@ export const DiscoverChart = ({

const histogramHeader = (
<EuiFlexGroup direction="column" gutterSize="xs">
<EuiFlexItem grow={false}>{hitsCounter}</EuiFlexItem>
<EuiFlexGroup direction="row" gutterSize="s">
<EuiFlexItem grow={true}>{hitsCounter}</EuiFlexItem>
<EuiFlexItem grow={false}>{discoverOptions}</EuiFlexItem>
</EuiFlexGroup>
<EuiFlexItem grow={false}>{isTimeBased && timeChartHeader}</EuiFlexItem>
<EuiFlexItem grow={false}>{discoverOptions}</EuiFlexItem>
</EuiFlexGroup>
);

Expand Down
Loading