[Fix] Replace segmented button with tabs for OpenSearch connections and Direct query connections #8460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <[email protected]>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8460 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3758 3758
Lines 89305 89304 -1
Branches 13972 13971 -1
=======================================
Hits 54439 54439
+ Misses 31478 31477 -1
Partials 3388 3388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Oct 7, 2024
ruanyl
approved these changes
Oct 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…nd Direct query connections (#8460) * replace segmented button with tabs Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #8460 created/updated --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 60df427) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 7, 2024
…nd Direct query connections (#8460) (#8510) * replace segmented button with tabs * Changeset file for PR #8460 created/updated --------- (cherry picked from commit 60df427) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace segmented button with tabs for OpenSearch connections and Direct query connections
Issues Resolved
Screenshot
before:
After:
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration