Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RemoteStoreReplicationSource#getSegmentFiles should be asynchronous #10619

Closed
andrross opened this issue Oct 13, 2023 · 0 comments · Fixed by #10725
Closed

[BUG] RemoteStoreReplicationSource#getSegmentFiles should be asynchronous #10619

andrross opened this issue Oct 13, 2023 · 0 comments · Fixed by #10725
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged

Comments

@andrross
Copy link
Member

The interface method in question here (SegmentReplicationSource#getSegmentFiles) takes a listener and is intended to be asynchronous, as it is in the node-to-node variant. The remote store version should be asynchronous as well instead of blocking the calling thread.
@andrross andrross added bug Something isn't working untriaged Indexing:Replication Issues and PRs related to core replication framework eg segrep labels Oct 13, 2023
@mch2 mch2 mentioned this issue Oct 19, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make RemoteStoreReplicationSource#getSegmentFiles asynchronous mch2/OpenSearch
1 participant
@andrross