-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pending _type
usages from the codebase
#3131
Labels
Comments
dreamer-89
added
enhancement
Enhancement or improvement to existing feature or request
untriaged
labels
May 2, 2022
This was referenced May 18, 2022
Closing this issue and target remaining type removal in #2979 post |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Creating this issue to list down pending
_type
usages from code bsae. Quick search on _type reveals below pending issues. More discussion here #2979 (comment)_type
should be addressed as any other random word in request body; which is already handled here. See this added previously and referred in BulkRequestParserTests insidetestTypesStillParsedForBulkMonitoring
. [Type removal] Remove type from BulkRequestParser #3423Identified other references which can be removed without any issue.
_ingest/pipeline/_simulate
API across multiple places. Verified that_type
is ignored by engine. Reference in a. IngestRequestConverterTests.java b. IngestClientIT.java in testSimulatePipeline c. grok_120.yml yaml tests [Type removal] Remove redundant _type in pipeline simulate action #3371type
in bulk action. [Type removal] Remove _type from _bulk yaml test, scripts, unused constants #3372_type
field. Probably ignored on engine side and thus can be removed [Type removal] Remove _type from _bulk yaml test, scripts, unused constants #3372_type
defined in Fields class. It is not referenced and can be removed. [Type removal] Remove _type from _bulk yaml test, scripts, unused constants #3372modules/reindex/src/test/resources/responses/*.json
[Type removal] _type removal from mocked responses of scroll hit tests #3377ClientYamlTestSuitesTests, DoSectionTests, OpenSearchClientYamlSuiteTestCaseTests
have hard-coded request body. [Type removal] _type removal from tests of yaml tests #3406The text was updated successfully, but these errors were encountered: