Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Fix message on enabling remote store without segment replication #4201

Closed
sachinpkale opened this issue Aug 12, 2022 · 0 comments
Labels
bug Something isn't working enhancement Enhancement or improvement to existing feature or request Indexing & Search

Comments

@sachinpkale
Copy link
Member

Describe the bug

  • Currently, if we try to enable index.remote_store.enabled without setting replication type to SEGMENT, we get following error:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "Settings index.remote_store.enabled cannot be enabled when index.replication.type is set to DOCUMENT"
      }
    ],
    "type" : "illegal_argument_exception",
    "reason" : "Settings index.remote_store.enabled cannot be enabled when index.replication.type is set to DOCUMENT"
  },
  "status" : 400
}
  • But this does not make the dependency of segment replication clear. With this change, we are changing the error message to:
{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "To enable index.remote_store.enabled, index.replication.type should be set to SEGMENT"
      }
    ],
    "type" : "illegal_argument_exception",
    "reason" : "To enable index.remote_store.enabled, index.replication.type should be set to SEGMENT"
  },
  "status" : 400
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhancement or improvement to existing feature or request Indexing & Search
Projects
None yet
Development

No branches or pull requests

2 participants