-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] S3RetryingInputStream incorrectly parses Content-Range value #9512
Labels
Comments
andrross
added
bug
Something isn't working
untriaged
distributed framework
v2.10.0
and removed
untriaged
labels
Aug 23, 2023
I actually think this bug can manifest in the |
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This REGEX is incorrect: https:/opensearch-project/OpenSearch/blob/main/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/utils/HttpRangeUtils.java#L20
It does not match the "bytes 0-100/200" format specified by RFC 9110.
The result is that readBlob(String, long, long) is broken, and searchable snapshots is therefore broken.
We are also missing coverage of this API in https:/opensearch-project/OpenSearch/blob/main/test/framework/src/main/java/org/opensearch/repositories/blobstore/OpenSearchBlobStoreRepositoryIntegTestCase.java
Related #9125
The text was updated successfully, but these errors were encountered: