-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ingest processor supports copying from one field to another #10529
Conversation
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change df21af1 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/observability.git, https:/opensearch-project/reporting.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/performance-analyzer.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/notifications.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/index-management.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/sql.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The failed test is a flaky test, there's an issue tracking it. |
This PR is stalled because it has been open for 30 days with no activity. |
Signed-off-by: Gao Binlong <[email protected]>
❌ Gradle check result for 6f3d0eb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test : #2775. |
@gaobinlong I restarted gradle check and checked the boxes in the description for you, but please do go through the checklist - for next one you can force push to your branch after a flaky test, and it will kick those things for you |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10529 +/- ##
============================================
- Coverage 71.30% 70.61% -0.69%
+ Complexity 59157 58571 -586
============================================
Files 4906 4906
Lines 278198 278215 +17
Branches 40422 40428 +6
============================================
- Hits 198358 196454 -1904
- Misses 63414 65269 +1855
- Partials 16426 16492 +66 ☔ View full report in Codecov by Sentry. |
@dblock thanks, now all checks have passed yet, could you help to review this PR? |
Not very familiar with this part of the code, maybe another maintainer can take a look? |
This PR is stalled because it has been open for 30 days with no activity. |
Signed-off-by: Gao Binlong <[email protected]>
❕ Gradle check result for df21af1: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Could anyone help to review this PR? It's been opened for months. |
Why we are not introducing dedicated |
While I get that the As a bonus, since you know that the source is definitely going to be another field, you could (for example) add a |
OK, implementing a new processor makes things simpler, and will not confuse users, I'll open another PR to implement |
Close this PR because #11870 has been merged. |
Description
When using template snippets like
{}
, the rendered result is always string, not the original field type, in order to implement copying from one field to another, this PR adds a new parameter namedcopy_from
for set processor which can be set to one of the field in the incoming document, and the value of that field will be copied deeply and assigned to the specified field.copy_from
andvalue
are mutually exclusive, either of them can be set.Related Issues
#10134
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.