Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Remaining Joda and Joda Dependency #10949

Closed
wants to merge 4 commits into from

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 26, 2023

Joda was deprecated in Elasticsearch 7.x. OpenSearch should have proactively removed in 2.0. This PR removes the remaining Joda dependency and formatting logic in favor of java 8 time. It adds a new LegacyFormatName class, however, to ensure camelCase DateFormat is supported for indexes created in ElasticSearch 7.x (and carried through OpenSearch 1.x).

relates #5910
relates #8110

Closes #3995

@nknize nknize requested a review from tlfeng as a code owner November 13, 2023 15:04
Copy link
Contributor

❌ Gradle check result for 5599d3e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Joda was deprecated in Elasticsearch 7.x. OpenSearch should have
proactively removed in 2.0. This commit removes the remaining Joda
dependency and formatting logic in favor of java 8 time. It adds a
new LegacyFormat class, however, to ensure camelCase DateFormat is
supported for indexes created in ElasticSearch 7.x (and carried through
OpenSearch 1.x).

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: Nicholas Walter Knize <[email protected]>
Copy link
Contributor

✅ Gradle check result for 07b930e: SUCCESS

@@ -325,7 +325,8 @@ private void init(FieldMapper toInit) {
setValue(initializer.apply(toInit));
}

private void parse(String field, ParserContext context, Object in) {
// public for testing only
public void parse(String field, ParserContext context, Object in) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This visibility change seems to be not needed, what test needs it?

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request labels Nov 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Jan 3, 2024
@ticheng-aws
Copy link
Contributor

Hi @nknize, the PR is stalled. Is this being worked upon?

@nknize
Copy link
Collaborator Author

nknize commented Jan 9, 2024

These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity.

@msfroh
Copy link
Collaborator

msfroh commented Jan 9, 2024

These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity.

To be fair, @reta reviewed it on November 13th, asked a question and got no reply.

@nknize nknize added feedback needed Issue or PR needs feedback stalled Issues that have stalled labels Jan 14, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 17, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Feb 22, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Mar 31, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label May 1, 2024
@nknize
Copy link
Collaborator Author

nknize commented Jul 1, 2024

won't be actively working unless needed

@nknize nknize closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility >breaking Identifies a breaking change. dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request feedback needed Issue or PR needs feedback pending backport Identifies an issue or PR that still needs to be backported stalled Issues that have stalled v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Joda and Joda Wrappers
5 participants