Add indexRandomForConcurrentSearch for tests: #11181

jed326 · 2023-11-13T20:48:39Z

MultiSearchIT.java
SimpleNestedIT.java
SearchPreferenceIT.java
SimpleQueryStringIT.java
ScriptQuerySearchIT.java

Description

Follow-up to #11065
Muted tests related to nested sorting that are flaky

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jed326 · 2023-11-13T21:15:10Z

Will backport this manually with #11118

server/src/internalClusterTest/java/org/opensearch/search/nested/SimpleNestedIT.java

github-actions · 2023-11-13T21:19:06Z

Compatibility status:

Checks if related components are compatible with change af84e28

Incompatible components

Incompatible components: [https:/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/security.git, https:/opensearch-project/alerting.git, https:/opensearch-project/index-management.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/sql.git, https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/observability.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/reporting.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/notifications.git, https:/opensearch-project/neural-search.git]

github-actions · 2023-11-13T21:34:00Z

❌ Gradle check result for b89a3bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-13T23:03:28Z

❌ Gradle check result for cb700e2: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

jed326 · 2023-11-13T23:12:19Z

Tracking the bugfix for the muted flaky tests here:

[Concurrent Segment Search] SimpleNestedIT tests using nested sort are flaky for concurrent segment search #11187

github-actions · 2023-11-13T23:24:40Z

❌ Gradle check result for d774636: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <[email protected]>

github-actions · 2023-11-13T23:58:08Z

✅ Gradle check result for 0dc7bed: SUCCESS

codecov · 2023-11-13T23:58:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8077a26) 71.12% compared to head (af84e28) 71.15%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11181      +/-   ##
============================================
+ Coverage     71.12%   71.15%   +0.02%     
- Complexity    58788    58799      +11     
============================================
  Files          4883     4883              
  Lines        277152   277152              
  Branches      40281    40281              
============================================
+ Hits         197134   197194      +60     
+ Misses        63545    63448      -97     
- Partials      16473    16510      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-11-14T00:35:33Z

❕ Gradle check result for af84e28: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testIndexReopenClose

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

jed326 · 2023-11-14T01:08:16Z

@reta @andrross @sohami could you help review + merge this one too? Thanks!

* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <[email protected]>

* Add indexRandomForConcurrentSearch method to tests: (#11118) * IndexStatsIT.java * SearchTimeoutIT.java * NaNSortingIT.java * NestedIT.java * RangeIT.java Signed-off-by: Jay Deng <[email protected]> * Add indexRandomForConcurrentSearch for tests: (#11181) * MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <[email protected]> * Fix tests for concurrent search with IndexRandomForConcurrentSearch follow-up [#11130] (#11212) Signed-off-by: Ganesh Ramadurai <[email protected]> Co-authored-by: Ganesh Ramadurai <[email protected]> * Fix tests for concurrent search (#11130) Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Ganesh Ramadurai <[email protected]> Co-authored-by: Ganesh Ramadurai <[email protected]> * Fixing the tests for concurrent search (#11076) * Fixing the tests for concurrent search Signed-off-by: Bansi Kasundra <[email protected]> * Remove changes for non-flaky tests Signed-off-by: Bansi Kasundra <[email protected]> --------- Signed-off-by: Bansi Kasundra <[email protected]> * Fixed test cases for concurrent search (#11184) Updated flaky and failing test cases after changes to indexRandomForConcurrentSearch Remove unnecessary call to indexRandomForConcurrentSearch in testSearchAndRelocateConcurrently Signed-off-by: Ethan Emoto <[email protected]> --------- Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Ganesh Ramadurai <[email protected]> Signed-off-by: Bansi Kasundra <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> Co-authored-by: Ganesh Krishna Ramadurai <[email protected]> Co-authored-by: Ganesh Ramadurai <[email protected]> Co-authored-by: Bansi Kasundra <[email protected]> Co-authored-by: Ethan Emoto <[email protected]>

* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <[email protected]>

* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>

jed326 added backport 2.x Backport to 2.x branch skip-changelog labels Nov 13, 2023

jed326 marked this pull request as ready for review November 13, 2023 20:49

jed326 removed the backport 2.x Backport to 2.x branch label Nov 13, 2023

neetikasinghal reviewed Nov 13, 2023

View reviewed changes

server/src/internalClusterTest/java/org/opensearch/search/nested/SimpleNestedIT.java Show resolved Hide resolved

jed326 force-pushed the 11065-followup branch from b89a3bd to cb700e2 Compare November 13, 2023 22:43

jed326 mentioned this pull request Nov 13, 2023

[Concurrent Segment Search] SimpleNestedIT tests using nested sort are flaky for concurrent segment search #11187

Closed

jed326 force-pushed the 11065-followup branch from cb700e2 to 0dc7bed Compare November 13, 2023 23:11

jed326 force-pushed the 11065-followup branch from 0dc7bed to d774636 Compare November 13, 2023 23:18

Add indexRandomForConcurrentSearch for tests:

af84e28

* MultiSearchIT.java * SimpleNestedIT.java * SearchPreferenceIT.java * SimpleQueryStringIT.java * ScriptQuerySearchIT.java Signed-off-by: Jay Deng <[email protected]>

jed326 force-pushed the 11065-followup branch from d774636 to af84e28 Compare November 13, 2023 23:43

jed326 mentioned this pull request Nov 13, 2023

[Bug] Gradle Check fails after ~5 minutes but the Jenkins job itself continues to run and sometimes even succeeds opensearch-project/opensearch-build#4212

Closed

neetikasinghal approved these changes Nov 14, 2023

View reviewed changes

sohami approved these changes Nov 14, 2023

View reviewed changes

sohami merged commit 3ff7e97 into opensearch-project:main Nov 14, 2023
29 checks passed

jed326 mentioned this pull request Nov 14, 2023

[Backport 2.x] Add indexRandomForConcurrentSearch for tests #11204

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add indexRandomForConcurrentSearch for tests: #11181

Add indexRandomForConcurrentSearch for tests: #11181

jed326 commented Nov 13, 2023

jed326 commented Nov 13, 2023

github-actions bot commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

jed326 commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

codecov bot commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 14, 2023

jed326 commented Nov 14, 2023

Add indexRandomForConcurrentSearch for tests: #11181

Add indexRandomForConcurrentSearch for tests: #11181

Conversation

jed326 commented Nov 13, 2023

Description

Check List

jed326 commented Nov 13, 2023

github-actions bot commented Nov 13, 2023 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

jed326 commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

codecov bot commented Nov 13, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 14, 2023

jed326 commented Nov 14, 2023

github-actions bot commented Nov 13, 2023 •

edited

Loading

codecov bot commented Nov 13, 2023 •

edited

Loading