Unmute nested sort related ITs

[jed326]

Description

Unmuting nested sort related tests for concurrent segment search. It's not super obvious why but both these tests and the underlying race condition itself was addressed by #11249.

The race condition comes from when SortBuilder::buildSort is called simultaneously by multiple threads which results in the LinkedListed in NestedScope being accessed concurrently leading to the stack traces found in #11187 & #11258.

In #11249 this was changed here to instead pass in the same SortAndFormats from the search context instead of rebuilding it on each thread. This means that we won't run into this same race condition anymore for nested sorts and I also verified that SortBuilder::buildSort is not called in a multi-threaded fashion from anywhere else.

Thus since the underlying problem has been addressed, unmuting these tests.

Related Issues

Resolves #11187
Resolves #11258

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[jed326]

@reta @sohami this PR is just unmuting some tests but please let me know if you would like to discuss anything else related to the original issues. Thanks!

[github-actions]

❌ Gradle check result for 7d7d798: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change 919c33d

Incompatible components

Skipped components

Compatible components

Compatible components: [https:/opensearch-project/asynchronous-search.git, https:/opensearch-project/security-analytics.git, https:/opensearch-project/observability.git, https:/opensearch-project/reporting.git, https:/opensearch-project/job-scheduler.git, https:/opensearch-project/opensearch-oci-object-storage.git, https:/opensearch-project/sql.git, https:/opensearch-project/custom-codecs.git, https:/opensearch-project/common-utils.git, https:/opensearch-project/security.git, https:/opensearch-project/notifications.git, https:/opensearch-project/anomaly-detection.git, https:/opensearch-project/ml-commons.git, https:/opensearch-project/index-management.git, https:/opensearch-project/neural-search.git, https:/opensearch-project/cross-cluster-replication.git, https:/opensearch-project/alerting.git, https:/opensearch-project/geospatial.git, https:/opensearch-project/k-nn.git, https:/opensearch-project/performance-analyzer-rca.git, https:/opensearch-project/performance-analyzer.git]

[github-actions]

❌ Gradle check result for 919c33d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jed326]

https://build.ci.opensearch.org/job/gradle-check/30538/

• [BUG] test failure ':sandbox:plugins:concurrent-search:test' QueryProfilePhaseTests.testTerminateAfterEarlyTermination #2775

There's a PR open already for this issue

[sohami]

@reta @sohami this PR is just unmuting some tests but please let me know if you would like to discuss anything else related to the original issues. Thanks!

I guess you can update the Description as root cause is now known.

It's not super obvious why but both these tests and the underlying race condition itself was addressed by https:/opensearch-project/OpenSearch/pull/11249.

[github-actions]

❕ Gradle check result for 919c33d: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testIndexReopenClose

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec5a0f9) 71.37% compared to head (919c33d) 71.31%.
Report is 9 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11377      +/-   ##
============================================
- Coverage     71.37%   71.31%   -0.06%     
- Complexity    58964    58966       +2     
============================================
  Files          4890     4890              
  Lines        277468   277468              
  Branches      40313    40313              
============================================
- Hits         198029   197873     -156     
- Misses        62945    63125     +180     
+ Partials      16494    16470      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.